From owner-freebsd-bugs@FreeBSD.ORG Mon Nov 19 13:50:02 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DDC216A46E for ; Mon, 19 Nov 2007 13:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E328A13C478 for ; Mon, 19 Nov 2007 13:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lAJDo1PO050664 for ; Mon, 19 Nov 2007 13:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lAJDo1bY050663; Mon, 19 Nov 2007 13:50:01 GMT (envelope-from gnats) Resent-Date: Mon, 19 Nov 2007 13:50:01 GMT Resent-Message-Id: <200711191350.lAJDo1bY050663@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, hsu@bbnetworks.net Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC0A016A41A for ; Mon, 19 Nov 2007 13:40:09 +0000 (UTC) (envelope-from root@ranta.suonsivu.net) Received: from ranta.suonsivu.net (ranta.suonsivu.net [212.16.100.98]) by mx1.freebsd.org (Postfix) with ESMTP id 8D26F13C447 for ; Mon, 19 Nov 2007 13:40:08 +0000 (UTC) (envelope-from root@ranta.suonsivu.net) Received: from ranta.suonsivu.net (localhost [127.0.0.1]) by ranta.suonsivu.net (8.14.2/8.14.1) with ESMTP id lAJCiQQQ002256 for ; Mon, 19 Nov 2007 14:44:26 +0200 (EET) (envelope-from root@ranta.suonsivu.net) Received: (from root@localhost) by ranta.suonsivu.net (8.14.2/8.14.1/Submit) id lAJCiQdZ002255; Mon, 19 Nov 2007 14:44:26 +0200 (EET) (envelope-from root) Message-Id: <200711191244.lAJCiQdZ002255@ranta.suonsivu.net> Date: Mon, 19 Nov 2007 14:44:26 +0200 (EET) From: hsu@bbnetworks.net To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/118123: /usr/bin/chat has infinite recursion bug X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: hsu@bbnetworks.net List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2007 13:50:02 -0000 >Number: 118123 >Category: bin >Synopsis: /usr/bin/chat has infinite recursion bug >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 19 13:50:01 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Heikki Suonsivu >Release: FreeBSD 7.0-BETA3 i386 >Organization: bbnetworks.net >Environment: System: FreeBSD ranta.suonsivu.net 7.0-BETA3 FreeBSD 7.0-BETA3 #2: Mon Nov 19 12:35:21 EET 2007 hsu@joutseno.wlansystems.com:/usr/obj/usr/src/sys/EBOX2300 i386 RELENG_6 and RELENG_7 >Description: chat will enter to infinite recursion if the tty disappears. This happens when a mobile phone disconnects during chat. >How-To-Repeat: Connect a mobile phone or other usb serial device, and unplug it when pppd is running chat. >Fix: --- chat.c.~1.21.~ Fri Oct 31 08:22:03 2003 +++ chat.c Sun Nov 4 12:02:43 2007 @@ -439,6 +439,22 @@ terminate(code); } +/* As above, but does not call terminate. This is for functions which + need to handle termination themselves, such as terminate(). */ + +void +fatal_no_terminate(int code, const char *fmt, ...) +{ + va_list args; + + va_start(args, fmt); + vfmtmsg(line, sizeof(line), fmt, args); + if (to_log) + syslog(LOG_ERR, "%s", line); + if (to_stderr) + fprintf(stderr, "%s\n", line); +} + int alarmed = 0; SIGTYPE sigalrm(int signo __unused) @@ -547,8 +563,10 @@ #if defined(get_term_param) if (have_tty_parameters) { - if (set_term_param (&saved_tty_parameters) < 0) - fatal(2, "Can't restore terminal parameters: %m"); + if (set_term_param (&saved_tty_parameters) < 0) { + fatal_no_terminate(2, "Can't restore terminal parameters: %m"); + status = 2; + } } #endif >Release-Note: >Audit-Trail: >Unformatted: