From owner-cvs-all Wed Apr 11 16:17:54 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 115C337B422; Wed, 11 Apr 2001 16:17:25 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f3BNGQb13203; Thu, 12 Apr 2001 00:16:26 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f3BNGB549681; Thu, 12 Apr 2001 00:16:11 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200104112316.f3BNGB549681@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Dima Dorfman Cc: Bruce Evans , John Baldwin , Kirk McKusick , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Brian Somers , brian@Awfulhak.org Subject: Re: cvs commit: src/bin/ps ps.c In-Reply-To: Message from Dima Dorfman of "Wed, 11 Apr 2001 15:24:20 PDT." <20010411222421.39B3C3E09@bazooka.unixfreak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 12 Apr 2001 00:16:11 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Bruce Evans writes: > > On Tue, 10 Apr 2001, John Baldwin wrote: > > > > > [ more to Brian than to Kirk ] > > > If all that is needed is a uniquifier for sessions, then why not use > > > the actual session ID itself: s_sid? It's already provided in > > > kinfo_proc as ki_sid even, ps(1) just doesn't use it at the moment. > > > That is probably much easier to parse than a kernel address. > > > > I agree that this would be better. In fact, Kirk added both ki_sid and > > ki_tsid. He apparently just forgot to actually use them :-). > > Then we're all in agreement. Now all we need is a patch. See attached. :-) > > Dima Dorfman > dima@unixfreak.org I've committed your patch. WRT the pstat side of things (``pstat -t'' shows the value of the tty's t_session pointer), the cleanest and least intrusive thing that comes to mind is to change t_session into a union and export the tsession_id to userland instead of the t_session pointer. Does anyone have any better suggestions ? -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message