Date: Tue, 5 Dec 2017 20:42:11 -0500 From: Allan Jude <allanjude@freebsd.org> To: cem@freebsd.org, Baptiste Daroussin <bapt@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316980 - head/contrib/zstd/programs Message-ID: <89b00017-aa92-66ca-5a28-47f0eb8f399b@freebsd.org> In-Reply-To: <CAG6CVpUCOUgT2S7MJXkingRmP04tgWehcE=v8R-casp8QsjTdg@mail.gmail.com> References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> <CAG6CVpUCOUgT2S7MJXkingRmP04tgWehcE=v8R-casp8QsjTdg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dDoRcaoxkuIdAdpg2aaiVWDTSSqBnR7dH Content-Type: multipart/mixed; boundary="D4rRGiNoViBIo1IUkF4sAuODgCglEDsRm"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: cem@freebsd.org, Baptiste Daroussin <bapt@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <89b00017-aa92-66ca-5a28-47f0eb8f399b@freebsd.org> Subject: Re: svn commit: r316980 - head/contrib/zstd/programs References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL+0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> <CAG6CVpUCOUgT2S7MJXkingRmP04tgWehcE=v8R-casp8QsjTdg@mail.gmail.com> In-Reply-To: <CAG6CVpUCOUgT2S7MJXkingRmP04tgWehcE=v8R-casp8QsjTdg@mail.gmail.com> --D4rRGiNoViBIo1IUkF4sAuODgCglEDsRm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2017-12-05 20:17, Conrad Meyer wrote: > Ping. Please revert this change. If you want zstd to behave this > way, pursue it upstream first. >=20 > Thanks, > Conrad >=20 > On Wed, Nov 15, 2017 at 7:38 PM, Conrad Meyer <cem@freebsd.org> wrote: >> Please revert this change. >> >> First, it introduces the POLA-violating behavior that zstdcat deletes >> its source files. This is not how zcat/bzcat behaves. >> >> Second, it introduces a needless behavioral difference between FreeBSD= >> zstd and the rest of the world's zstd. The zstd documentation we ship= >> continues to claim that zstd preserves source files by default, yet >> this change makes that documentation exactly backwards. While we can >> change FreeBSD's documentation to accommodate the change, we can't >> change Google results. >> >> Thanks, >> Conrad >> >> On Sat, Apr 15, 2017 at 1:15 PM, Baptiste Daroussin <bapt@freebsd.org>= wrote: >>> Author: bapt >>> Date: Sat Apr 15 20:15:44 2017 >>> New Revision: 316980 >>> URL: https://svnweb.freebsd.org/changeset/base/316980 >>> >>> Log: >>> Change some default to make zstd a dropin replacement for gzip,bzip= etc >>> in most cases >>> >>> Changes ares: >>> - quiet by default >>> - remove the source files one compression completion by default >>> >>> Modified: >>> head/contrib/zstd/programs/fileio.c >>> head/contrib/zstd/programs/zstdcli.c >>> >>> Modified: head/contrib/zstd/programs/fileio.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/contrib/zstd/programs/fileio.c Sat Apr 15 20:06:24 2017 = (r316979) >>> +++ head/contrib/zstd/programs/fileio.c Sat Apr 15 20:15:44 2017 = (r316980) >>> @@ -138,7 +138,7 @@ static U32 g_dictIDFlag =3D 1; >>> void FIO_setDictIDFlag(unsigned dictIDFlag) { g_dictIDFlag =3D dictI= DFlag; } >>> static U32 g_checksumFlag =3D 1; >>> void FIO_setChecksumFlag(unsigned checksumFlag) { g_checksumFlag =3D= checksumFlag; } >>> -static U32 g_removeSrcFile =3D 0; >>> +static U32 g_removeSrcFile =3D 1; >>> void FIO_setRemoveSrcFile(unsigned flag) { g_removeSrcFile =3D (flag= >0); } >>> static U32 g_memLimit =3D 0; >>> void FIO_setMemLimit(unsigned memLimit) { g_memLimit =3D memLimit; }= >>> >>> Modified: head/contrib/zstd/programs/zstdcli.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:06:24 2= 017 (r316979) >>> +++ head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:15:44 2= 017 (r316980) >>> @@ -61,7 +61,7 @@ >>> #define MB *(1 <<20) >>> #define GB *(1U<<30) >>> >>> -#define DEFAULT_DISPLAY_LEVEL 2 >>> +#define DEFAULT_DISPLAY_LEVEL 1 >>> >>> static const char* g_defaultDictName =3D "dictionary"; >>> static const unsigned g_defaultMaxDictSize =3D 110 KB; >>> >=20 Upstream recommends we create an additional hardlink, called 'zz' (like xz but zstd), to do such compatibility, and keep 'zstd' the same as zstd on every other distro. --=20 Allan Jude --D4rRGiNoViBIo1IUkF4sAuODgCglEDsRm-- --dDoRcaoxkuIdAdpg2aaiVWDTSSqBnR7dH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJaJ0r7AAoJEBmVNT4SmAt+OEEP/R0ScQayJ4evMsZYY0+w3naW XeQaNGTDpx4Cmepn1hfFD4nx2uOlMrlvlSpTKoCovEyB9D0kVaSbiO5/xYKayg2K pLcdaWWV+3+Fj1Lfryqt90eAzUNZFjg2T9eIHj80UyUHwbZ4cEHXqaFaDQW6X4yx 62ARgnQosCv8M0yeZIEU2F4ifkft20bVLlWOm5J5BlHC3GHB80wKb9uZe6idM78E BIhMCuge/GOokXyDe3qS7iKvrtuhV9AnsaWWX0VprCR1p9kI+fAjy40f/2WOSlEB RBU+Wt1ilbgXbTEOKB7j6P2epkxYoYA+Quky1ToEqE/5mMMHylnws7Fg3jZMVfAJ Oh3hgln8waOZrrf9Rke1XSq12ket/xzSblZle3MfNI3jvYAPBLD1nq4zErqS+5cv Te1FB2S5H4XhEgAtdTZWT9oBk0Vq+JMwHqFepG7KO4SP08kRmn47TajUR1bo8Hm5 BSvjTpF233fHl2EUjEnVSpWk0kh9Z/nrp/ogodHJAkXO8PJl0d8o+qRQ02nffaeU +6HGon0DpCD++i+KSEBS14IQMjDCmW3XOFitr28LX9K7HeoDgs1hV5mzi/2XXDEq tRlxvhR5C0TujR1C7Tpyr+T9Fba3fEfu9PNfy/qMkvFk+Hi5TFRFOEni4z1ye3el OxswnhR5OVAoZLuYQFsG =ouH2 -----END PGP SIGNATURE----- --dDoRcaoxkuIdAdpg2aaiVWDTSSqBnR7dH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?89b00017-aa92-66ca-5a28-47f0eb8f399b>