From owner-cvs-ports@FreeBSD.ORG Sun Dec 6 13:18:17 2009 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05501106568D; Sun, 6 Dec 2009 13:18:17 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-iw0-f198.google.com (mail-iw0-f198.google.com [209.85.223.198]) by mx1.freebsd.org (Postfix) with ESMTP id 944848FC16; Sun, 6 Dec 2009 13:18:16 +0000 (UTC) Received: by iwn36 with SMTP id 36so2480710iwn.3 for ; Sun, 06 Dec 2009 05:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=2gUrIbJzYIcDhJzTWzkoV4g4S3LKXcX9U1Cb80HKi4k=; b=jSSqTJUd9xlBlHBffE9KQ11x+tiaQai4Xyhl/B99jXxSawDqNyp2wb6iHURuwaz5HJ 0f9Y2hTlmaGEExm5TEdOhnfoAts1yrik9VG/QmcfUbLTXlsCGxzFeifdU9fV8EvGomBq LABccJuSEEbZSZ/GdR+oCi2UsvpYKm2yHVuzI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=d4wHk0h9IPhlgyoLROqIJ2ST/9mwI9CTLlR7Bp/YvPD1KBMhLXZw8CA+gWDC/vSbGD do9NaYFfr2ALMWXWURAfoTNSQe95uijUCNDpcnQN0AXnGyyjUJjtWSY8MUQLqLtU+rKB O6w7d7GiDuvn7ij/rzbsx7p8GLlow/buUTTWI= MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.231.25.199 with SMTP id a7mr1161577ibc.51.1260103624644; Sun, 06 Dec 2009 04:47:04 -0800 (PST) In-Reply-To: <4B1B84DC.3040104@FreeBSD.org> References: <200912060958.nB69wwlm088487@repoman.freebsd.org> <4B1B84DC.3040104@FreeBSD.org> Date: Sun, 6 Dec 2009 20:47:04 +0800 X-Google-Sender-Auth: c313bf7397a10928 Message-ID: From: Adrian Chadd To: Gabor Kovesdan Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/lusca-head/files patch-ab patch-ac X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2009 13:18:17 -0000 I'm sorry for the drive-by commits like this - I had tested the port locally and deployed it in production; I didn't realise there were so many issues until after the commit. I plan on bumping the port revision once I've established that all of the post-install issues are fixed. I think they are now. I apologies for the noise, Adrian 2009/12/6 Gabor Kovesdan : > Adrian Chadd escribi=F3: >> >> adrian =A0 =A0 =A02009-12-06 09:58:58 UTC >> >> =A0FreeBSD ports repository (src committer) >> >> =A0Added files: >> =A0 =A0www/lusca-head/files patch-ab patch-ac =A0Log: >> =A0* Don't install the 'templates' error page directory. It isn't requir= ed. >> =A0* Default to "English" instead of "templates" in the configure script > > And what about the PORTREVISION bump, which is mandatory after changing t= he > install process? You know that, don't you? It would be better if you aske= d a > ports committer to help you and especially to *approve* your changes. You= r > recent commits are far from any of our conventions. I don't even dare to = ask > if you tested this on a ports tinderbox. With your src commit bit you are > able to commit to the ports tree but it doesn't mean that you can do > whatever you want. It isn't quite usual that doc/ports committers ignore > rules and commit something wrong to src without approval but it is much m= ore > common that src committers commit awkward doc and *especially* ports > changes. I would like to call the community attention (not just yours) th= at > the highest importance of the src tree doesn't mean that src committers c= an > do whatever they want in the doc and ports trees. We have our own > conventions and rules here, please respect them and ask approval from a > ports committer if you are unsure. There are a lot of helpful people, who > are glad to help and review patches. I also do that when I have time. > > -- > Gabor Kovesdan > FreeBSD Volunteer > > EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org > WEB: =A0 http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org > >