From owner-cvs-all Thu Jan 4 14: 6:40 2001 From owner-cvs-all@FreeBSD.ORG Thu Jan 4 14:06:37 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [62.232.68.68]) by hub.freebsd.org (Postfix) with ESMTP id BABE737B402; Thu, 4 Jan 2001 14:06:36 -0800 (PST) Received: from originative.co.uk (tiddler.originative.co.uk [62.232.68.83]) by mailgate.originative.co.uk (Postfix) with ESMTP id 67E8E1D140; Thu, 4 Jan 2001 22:06:14 +0000 (GMT) Sender: paul@originative.co.uk Message-ID: <3A54F477.DCD11D4B@originative.co.uk> Date: Thu, 04 Jan 2001 22:08:55 +0000 From: Paul Richards X-Mailer: Mozilla 4.75 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Tony Finch Cc: Paul Richards , Dag-Erling Smorgrav , Mark Murray , Paul Richards , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/update pkg_update.pl References: <200101041509.f04F9kY06526@gratis.grondar.za> <3A54A329.3A84087F@freebsd-services.co.uk> <20010104214946.W2140@hand.dotat.at> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Tony Finch wrote: > > Paul Richards wrote: > > > >sysopen() is not portable, it is a wrapper to the underlying OS open() > >call and as such you have to know what the OS file modes are. > > You can easily get that information by using POSIX.pm. I could yes, but I could just open properly since that's a lot easier. The mistake was using "<$file", what I should have done was use the list version i.e. open(HANDLE, "<", $file) and then there wouldn't have any issues at all, though Mark makes a valid point about taint checking. Paul. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message