Date: Sat, 25 Jun 2016 16:03:27 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Guy Yur <guyyur@gmail.com>, Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Samba 4.3 and 4.4 crashes on FreeBSD 11-ALPHA4 Message-ID: <1a0a1d8e-f325-1ae7-3d85-7013726305a5@pyret.net> In-Reply-To: <CAC67Hz-aX5xm_34jOBd=_W%2BwrYAt5OQ%2BMPH%2BFxWWcEb4%2B4KOdA@mail.gmail.com> References: <CAC67Hz_BmCpbU1UONPgpGY4kNvJj9GQCoAwqOO_19vZL2-6xyQ@mail.gmail.com> <20160625084939.GI38613@kib.kiev.ua> <20160625092040.GL38613@kib.kiev.ua> <CAC67Hz-aX5xm_34jOBd=_W%2BwrYAt5OQ%2BMPH%2BFxWWcEb4%2B4KOdA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-06-25 12:16, Guy Yur wrote: > Hi, > > On Sat, Jun 25, 2016 at 12:20 PM, Konstantin Belousov > <kostikbel@gmail.com> wrote: >> On Sat, Jun 25, 2016 at 11:49:39AM +0300, Konstantin Belousov wrote: >>> On Sat, Jun 25, 2016 at 01:03:13AM +0300, Guy Yur wrote: >>>> libtdb.so.1`tdb_runtime_check_for_robust_mutexes + 1475 at mutex.c:957 >>>> ... >>> >>> The pointer to tdb_runtime_check_for_robust_mutexes() appeared to be >>> most useful, thanks. >>> >>> The two patches below should fix samba use of robustness. First, >>> kernel erronously reset robust lists locations on fork. Second, the >>> pthread_mutex_trylock() for owned errorcheck mutex must return EDEADLK >>> and not EBUSY. Try that. >> >> Correction, there was a reason why I initially put the rb list pointers >> into zeroed region. It still needs to be zeroed on new thread creation. >> Updated patch. >> > > With the patch to the 3 files applied, smbd, nmbd and smbclient > no longer crash on my machine. > > Tested with r302191+patch. > > Thanks, > Guy > Hi, Sorry for being late to the party :/ I've tested your patch (the latest one) and it also seems to do the trick. Thanks! FreeBSD 11.0-ALPHA5 (AMD64) - Samba 4.4 Best regards, Daniel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1a0a1d8e-f325-1ae7-3d85-7013726305a5>