From owner-svn-src-all@FreeBSD.ORG Wed Jan 28 03:29:29 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D91D3E6D for ; Wed, 28 Jan 2015 03:29:29 +0000 (UTC) Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A8C0FAF6 for ; Wed, 28 Jan 2015 03:29:29 +0000 (UTC) Received: by mail-pa0-f49.google.com with SMTP id fa1so22622578pad.8 for ; Tue, 27 Jan 2015 19:29:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=quBAMn75O5BySpctQP4J5GzZKW+nn1o5TdZgmHm01Ik=; b=KE9eEHU7URqVPM929s9QsmxcMdQfSYhb2RpuQx6PmuIwxXfTMKqDPMS5ZkAoAovSMZ UXQvktpDfrjDQC9sfkCN0LsJCkISDt04daFdeiWgz+JS4TlIlD4Oisu/+0eZjAwk7IY1 uOywMfz145lUAmcJr5tEvjAWw41voMhjJmKk/f1v5Mb+5ag/uSv5dd1IdYx3j0zTonJF tpyD/C/hHrXSJaTMhndW2u7uMjIA3xAuMajHkPPMfdTzIEuG8NkeBltq1VDh8MBEY7qf k3iDwBSqKVb4VhPzlgNlBvPIiZ64+blLFMpEveh8WeKLXO+O7+gtRKsITw0YxbuokEh8 e+Rg== X-Gm-Message-State: ALoCoQkoOzfI6zTbrDhfQUtisQh8ez8MnNcB38YOnDK7G1RPhi36c3dI1Pk33e7niUdty1RQuGGR X-Received: by 10.70.95.133 with SMTP id dk5mr2188403pdb.98.1422415762835; Tue, 27 Jan 2015 19:29:22 -0800 (PST) Received: from [10.64.24.223] ([69.53.236.236]) by mx.google.com with ESMTPSA id pp9sm2991596pbb.65.2015.01.27.19.29.20 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 Jan 2015 19:29:21 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk From: Warner Losh In-Reply-To: Date: Tue, 27 Jan 2015 20:29:18 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <35AB8592-7ACA-4352-8448-F7EFA0F861CD@bsdimp.com> References: <201501260850.t0Q8oDna015719@svn.freebsd.org> <86fvax91cy.fsf@nine.des.no> To: Garrett Cooper X-Mailer: Apple Mail (2.1993) Cc: svn-src-head@freebsd.org, =?windows-1252?Q?Dag-Erling_Sm=F8rgrav?= , svn-src-all@freebsd.org, src-committers , Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 03:29:29 -0000 > On Jan 26, 2015, at 7:26 PM, Garrett Cooper = wrote: >=20 > On Jan 26, 2015, at 4:23, Dag-Erling Sm=F8rgrav wrote: >=20 >> Garrett Cooper writes: >>> Log: >>> Honor MK_ACCT with etc/pam.d/atrun >>=20 >> The correct idiom would be >=20 > I disagree for a few reasons: > 1. style.Makefile(9) makes no mention of having to use an idiom over = the other. > 2. The likelihood of typos creeping into Makefiles is greater with the = _foo=3D idiom. > 3. It creates unnecessary local variables =97 especially when = appending is so easy to do. > 4. It=92s more difficult when backporting changes to do it with the = variable method =97 especially if context around the line modified has = changed a great deal. 5. I=92m working on a change that would be easier to do with Garrett=92s = change, but it is rather invasive so I need to work it through a good = chunk of the system before I offer it for review and discussion. Warner=