Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Apr 2020 16:02:43 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r359518 - stable/11/sys/x86/x86
Message-ID:  <202004011602.031G2hRi004510@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Apr  1 16:02:42 2020
New Revision: 359518
URL: https://svnweb.freebsd.org/changeset/base/359518

Log:
  MFC r359093:
  Do not spuriously re-enable disabled io_apic pin on EOI for some configurations.

Modified:
  stable/11/sys/x86/x86/io_apic.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/x86/x86/io_apic.c
==============================================================================
--- stable/11/sys/x86/x86/io_apic.c	Wed Apr  1 16:01:03 2020	(r359517)
+++ stable/11/sys/x86/x86/io_apic.c	Wed Apr  1 16:02:42 2020	(r359518)
@@ -191,8 +191,11 @@ _ioapic_eoi_source(struct intsrc *isrc, int locked)
 		low1 |= IOART_TRGREDG | IOART_INTMSET;
 		ioapic_write(io->io_addr, IOAPIC_REDTBL_LO(src->io_intpin),
 		    low1);
+		low1 = src->io_lowreg;
+		if (src->io_masked != 0)
+			low1 |= IOART_INTMSET;
 		ioapic_write(io->io_addr, IOAPIC_REDTBL_LO(src->io_intpin),
-		    src->io_lowreg);
+		    low1);
 		if (!locked)
 			mtx_unlock_spin(&icu_lock);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004011602.031G2hRi004510>