From owner-svn-src-head@FreeBSD.ORG Fri May 11 17:04:17 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A064106566C; Fri, 11 May 2012 17:04:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id B8E268FC16; Fri, 11 May 2012 17:04:16 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q4BH4DDE084811; Fri, 11 May 2012 20:04:13 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q4BH4CK9036734; Fri, 11 May 2012 20:04:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q4BH4C7H036733; Fri, 11 May 2012 20:04:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 11 May 2012 20:04:12 +0300 From: Konstantin Belousov To: Andrey Chernov , Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <20120511170412.GR2358@deviant.kiev.zoral.com.ua> References: <201205111129.q4BBT85G081093@svn.freebsd.org> <20120511145432.GA19173@vniz.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QjyiCFk1yXa15KPn" Content-Disposition: inline In-Reply-To: <20120511145432.GA19173@vniz.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Subject: Re: svn commit: r235266 - head/lib/libc/stdlib X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2012 17:04:17 -0000 --QjyiCFk1yXa15KPn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 11, 2012 at 06:54:32PM +0400, Andrey Chernov wrote: > Thanks, but in this two places old errno value should be saved across > free() because free() may damage it: I do not agree. free() cannot change errno. >=20 > On Fri, May 11, 2012 at 11:29:08AM +0000, Konstantin Belousov wrote: > ... > > + if (lstat(resolved, &sb) !=3D 0) { > > + if (m) > > + free(resolved); > > + > return (NULL); > ... > > + errno =3D ENOTDIR; > > if (m) > > free(resolved); > > return (NULL); >=20 --QjyiCFk1yXa15KPn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+tRosACgkQC3+MBN1Mb4j+YQCgrlfXN2Ip4mlwRoeEi4tnIbDv ujYAoJ71OuDNL42dKPGDPL0+pQlUrHwa =n1I7 -----END PGP SIGNATURE----- --QjyiCFk1yXa15KPn--