Date: Thu, 10 Sep 2015 13:06:57 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 203011] net/xorp: fix build on 9.x or mark broken everywhere Message-ID: <bug-203011-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203011 Bug ID: 203011 Summary: net/xorp: fix build on 9.x or mark broken everywhere Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: hrs@FreeBSD.org Reporter: amdmi3@FreeBSD.org Assignee: hrs@FreeBSD.org Flags: maintainer-feedback?(hrs@FreeBSD.org) Created attachment 160892 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=160892&action=edit Patch I've tried to fix xorg on 9.x: http://beefy2.nyi.freebsd.org/data/93amd64-default/396547/logs/errors/xorp-1.8.5.log there's a patch for SConstruct which is pretty much broken, as it tries to pass "-Werror -Wno-unused-function" compiler flag as a single argument. Also localbase patching is broken and in addition -Wno-unused-functions part of the patch is duplicated with REINPLACE_CMD. I've fixed the patch, and now it builds fine on both 9.x and 10.x, however no more on 11.x: ./libxorp/ref_trie.hh:1359:9: error: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to false [-Werror,-Wtautological-undefined-compare] if (this == NULL) { ^~~~ ~~~~ because -Werror flag is not interpreted correctly. The problem however is not the flag but broken upstream code which causes undefined behavior, this the application may not work properly regardless of whether it compiles. Upstream seems pretty inactive, so now I wonder what should we do: remove -Werror, or mark it BROKEN. We could also fix trie code, but it'll require some work and much testing. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203011-13>