Date: Tue, 18 Nov 2014 17:07:03 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r274669 - head/sys/arm/broadcom/bcm2835 Message-ID: <201411181707.sAIH73Dx052324@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Tue Nov 18 17:07:02 2014 New Revision: 274669 URL: https://svnweb.freebsd.org/changeset/base/274669 Log: These delays aren't needed. Elimate them. They should be on the order of a few cycles at most, not 10us. They make it impossible to implement half-duplex protocols that are faster than about 1KHz. Sponsored by: Netflix Modified: head/sys/arm/broadcom/bcm2835/bcm2835_gpio.c Modified: head/sys/arm/broadcom/bcm2835/bcm2835_gpio.c ============================================================================== --- head/sys/arm/broadcom/bcm2835/bcm2835_gpio.c Tue Nov 18 17:06:56 2014 (r274668) +++ head/sys/arm/broadcom/bcm2835/bcm2835_gpio.c Tue Nov 18 17:07:02 2014 (r274669) @@ -238,9 +238,7 @@ bcm_gpio_set_pud(struct bcm_gpio_softc * offset = pin - 32 * bank; BCM_GPIO_WRITE(sc, BCM_GPIO_GPPUD(0), state); - DELAY(10); BCM_GPIO_WRITE(sc, BCM_GPIO_GPPUDCLK(bank), (1 << offset)); - DELAY(10); BCM_GPIO_WRITE(sc, BCM_GPIO_GPPUD(0), 0); BCM_GPIO_WRITE(sc, BCM_GPIO_GPPUDCLK(bank), 0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201411181707.sAIH73Dx052324>