From owner-cvs-all  Thu Sep 27 15:46:56 2001
Delivered-To: cvs-all@freebsd.org
Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40])
	by hub.freebsd.org (Postfix) with ESMTP
	id AD49D37B401; Thu, 27 Sep 2001 15:46:50 -0700 (PDT)
Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47])
	by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f8RMkhx168936;
	Thu, 27 Sep 2001 18:46:43 -0400
Mime-Version: 1.0
X-Sender: drosih@mail.rpi.edu
Message-Id: <p0510100cb7d95a806546@[128.113.24.47]>
In-Reply-To: 
 <Pine.BSF.4.21.0109271531150.65838-100000@InterJet.elischer.org>
References: 
 <Pine.BSF.4.21.0109271531150.65838-100000@InterJet.elischer.org>
Date: Thu, 27 Sep 2001 18:46:40 -0400
To: Julian Elischer <julian@elischer.org>,
	John Baldwin <jhb@FreeBSD.org>
From: Garance A Drosihn <drosih@rpi.edu>
Subject: Re: cvs commit: src/sys/sys proc.h
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

At 3:38 PM -0700 9/27/01, Julian Elischer wrote:
>Pitty:
>
>I think
>         pid_t           p_oppid;        /* (c + e) Save ppid in ptrace.*/
>         struct vmspace  *p_vmspace;     /* (b) Address space. */
>         u_int           p_swtime;       /* (j) Time swapped in or out. */
>         struct itimerval p_realtimer;   /* (h?/k?) Alarm timer. */

>is more readable than
>
>         pid_t   p_oppid;                /* (c + e) Save ppid in ptrace.*/
>         struct  vmspace *p_vmspace;     /* (b) Address space. */
>         u_int   p_swtime;               /* (j) Time swapped in or out. */
>         struct  itimerval p_realtimer;  /* (h?/k?) Alarm timer. */

When mixing a lot of structs and "shortname types" like this, I do
prefer the looks of the first over the second.  I guess I'd do it
as "tab tab space" for non-pointers, and "tab tab asterisk" for the
pointers.

I can see how others might not like that, and I don't feel particularly
strongly about it.  But if someone were to ask for a simple-vote on the
matter, I would vote for the first one (well, with the extra blank in
there for non-pointers).

Just my 2-cents worth.

-- 
Garance Alistair Drosehn            =   gad@eclipse.acs.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message