From owner-freebsd-geom@FreeBSD.ORG  Tue Jan 27 06:57:08 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A30F16A4CE
	for <freebsd-geom@freebsd.org>; Tue, 27 Jan 2004 06:57:08 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A7EF243D6B
	for <freebsd-geom@freebsd.org>; Tue, 27 Jan 2004 06:56:57 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id i0REutuO004822;
	Tue, 27 Jan 2004 15:56:55 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Lukas Ertl <l.ertl@univie.ac.at>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 27 Jan 2004 15:46:30 +0100."
             <20040127154303.E92925@pcle2.cc.univie.ac.at> 
Date: Tue, 27 Jan 2004 15:56:55 +0100
Message-ID: <4821.1075215415@critter.freebsd.dk>
cc: freebsd-geom@freebsd.org
Subject: Re: Error checking for g_mod_event() and friends 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jan 2004 14:57:08 -0000

In message <20040127154303.E92925@pcle2.cc.univie.ac.at>, Lukas Ertl writes:
>Hi,
>
>is there a specific reason that the .init function of a class is declared
>to return "void"?  I'd like to change that to an int, so we could do error
>checking, and subsequently modify g_load_class() to check for errors and
>so on.

In what circumstances would class->init() fail ?

>Additionally, I've seen several calls to g_malloc() where the return
>values aren't checked - should I prepare some patches for these?

yes please.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.