From owner-freebsd-current@FreeBSD.ORG Thu Nov 3 12:40:36 2005 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCF8C16A41F; Thu, 3 Nov 2005 12:40:36 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-3-1-cust208.cdif.cable.ntl.com [82.31.78.208]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5503443D45; Thu, 3 Nov 2005 12:40:34 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.54 (FreeBSD)) id 1EXeOJ-000PY8-N1; Thu, 03 Nov 2005 12:40:27 +0000 Date: Thu, 3 Nov 2005 12:40:27 +0000 From: Ceri Davies To: Brooks Davis , bushman@rsu.ru Message-ID: <20051103124027.GE29387@submonkey.net> Mail-Followup-To: Ceri Davies , Brooks Davis , bushman@rsu.ru, hackers@FreeBSD.org, current@FreeBSD.org References: <20051102001507.GB14638@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rE45P3aZNSuYx5ND" Content-Disposition: inline In-Reply-To: <20051102001507.GB14638@odin.ac.hmc.edu> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: hackers@FreeBSD.org, current@FreeBSD.org Subject: Re: nsswitch reviewer wanted X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2005 12:40:37 -0000 --rE45P3aZNSuYx5ND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In the list that shall not be cc'd to, on Tue, Nov 01, 2005 at 04:15:07PM -0800, Brooks Davis wrote: > Michael Bushkov disk some interesting work for use under the Google > Summer of Code and I'd like to see the appropriate parts committed. > Unfortunately, this isn't an area I have great depths of knowledge so > I'm hoping someone one else is interested in working on this. I realise that you weren't asking for comments, but I took a quick look at http://www.rsu.ru/~bushman/nsswitch_cached/nss_cached.patch and have some. I'll send this to the original lists too. o There aren't nearly enough comments. Granted, I'm not a C aficionado, but it's ~ line 3200 of that patch before we come to a new non-trivial comment, and there aren't many after that. o cached/config.c has magic numbers in create_def_configuration_entry(), which probably belong as #defines in config.h instead. I'm not sure what style(9) says about that though, so am happy to be ignored. o There is a single mention of a ssh_hostkeys cache in include/nsswitch.h, and no code to implement it. o On line 15448, there is a whitespace nit. Also, in this area, are we sure that there is no benefit in continuing to key by euid/egid if perform_actual_lookup is enabled; can we send the euid/egid with the lookup request? o A user should be able to invalidate one of their caches (e.g., "cached -i hosts" to flush their hosts cache). Root should be able to do it for all users with a single command (e.g., "cached -I hosts" to flush all hosts caches). o The manual for cached.conf is unclear over whether it's OK to name an "unknown" cache in cached.conf. o The location of cached.conf is defaulted to /usr/local/etc in cached/cached.c and should be changed on commit. Ceri --=20 Only two things are infinite, the universe and human stupidity, and I'm not sure about the former. -- Einstein (attrib.) --rE45P3aZNSuYx5ND Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDagU7ocfcwTS3JF8RAqJkAKCmjV5v4UrUzWyCsJ9i/8u+zXZGAgCdHgCJ 0KhNqHhqRKr6oXxXBa/qtFE= =tJO2 -----END PGP SIGNATURE----- --rE45P3aZNSuYx5ND--