From owner-svn-ports-all@FreeBSD.ORG Mon Jan 13 00:26:57 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 45D2EF14; Mon, 13 Jan 2014 00:26:57 +0000 (UTC) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 61F4B1F11; Mon, 13 Jan 2014 00:26:56 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id a1so3686465wgh.4 for ; Sun, 12 Jan 2014 16:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=p2yLIHAtYLltWHdRWP7rSNG6iuwRIas2OXhVK1FYZds=; b=JyVxLh9eFWqg1dOYWLXBTx6zn87yo3ZzcUoKuRexPWvhx2tFTaIeek3iMea2iypskg fcVLDZQFLwaiJH8fKgpLt0t3IoAesc/e8xtOn4h6/OF7QWnQ5+Oru4mMeOZI0+rakT18 QFMV1B3DVjehtRJEZ52iqpm31PKnj1A06YTvl3UwAumOZ9zQFmo+UUHQ8DJw8bhmx9ew gNcXPy4PrZGigpKgm4XPugAeZ1cjr8/jwYtXG6sGzLgvNkEts95qgWOYzqftLaaEpIYD KbOVBgN2oYJ4Mm2uTJN/pYP7khrH4YyrnKcdYhfMZFIusaBVOztEjAZHJZg+VxHyJYmJ tRyQ== X-Received: by 10.180.211.161 with SMTP id nd1mr10570684wic.41.1389572814950; Sun, 12 Jan 2014 16:26:54 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id f7sm10099931wjb.7.2014.01.12.16.26.53 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 12 Jan 2014 16:26:54 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 13 Jan 2014 01:26:52 +0100 From: Baptiste Daroussin To: Chris Rees Subject: Re: svn commit: r339550 - in head/Mk: . Uses Message-ID: <20140113002652.GN97375@ithaqua.etoilebsd.net> References: <201401122116.s0CLG6Wn016253@svn.freebsd.org> <20140113002034.GM97375@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i6vqABX3nJKXLk01" Content-Disposition: inline In-Reply-To: <20140113002034.GM97375@ithaqua.etoilebsd.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 00:26:57 -0000 --i6vqABX3nJKXLk01 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 13, 2014 at 01:20:34AM +0100, Baptiste Daroussin wrote: > On Sun, Jan 12, 2014 at 09:16:06PM +0000, Chris Rees wrote: > > Author: crees > > Date: Sun Jan 12 21:16:06 2014 > > New Revision: 339550 > > URL: http://svnweb.freebsd.org/changeset/ports/339550 > >=20 > > Log: > > Strip postgresql code out of bsd.database.mk, and introduce USES=3Dpg= sql. > > =20 > > New syntax: > > =20 > > # Depend on postgresql-client > > USES=3D pgsql > > =20 > > # Depend on postgresql-client at least 9.2 > > USES=3D pgsql:9.2+ > > =20 > > #Depend on postgresql-server at least 9.0 > > USES=3D pgsql:9.0+ > > WANT_PGSQL=3D server > > =20 > > Postgresql now supports DEFAULT_VERSIONS, and please note that the > > version syntax now includes dots(!); i.e. before it was 90, now 9.0 > > =20 > > Reviewed by: ade, silence from pgsql@ > >=20 >=20 > It is broken in multiple parts first WANT_PGSQL is checked even when not = defined > resulting multiple lines like: > /usr/ports/Mk/Uses/pgsql.mk" line 128: Malformed conditional (${WANT_PGSQ= L:M${:Ucontrib}}) > if a port only defines USES=3Dpgsql >=20 > If the first is fixed then the version is not properly defined resulting = in a > dependency like: > /usr/ports/databases/postgresql-client which doesn't exists. >=20 > For this kind of change a portmgr review would have been nice and an exp-= run > even better. Yet more things: there is mess up between what should be run in pre or post section which is normally one of the things USES should solve and makes Mk/* inefficient and lots of the time not predictable this is a major pain when debugging. Bapt --i6vqABX3nJKXLk01 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLTMswACgkQ8kTtMUmk6Ez77ACcD0Pp0wrGYSnEmHYrF7BjCHu6 JqEAn0KbhKGON3C1i9goUHWO2igg4LG9 =3C3B -----END PGP SIGNATURE----- --i6vqABX3nJKXLk01--