Date: Wed, 08 Sep 2021 12:58:45 +0000 From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 258271] www/chromium: Makefile warning for grep mempcpy /usr/include/string.h. This warning is redundant and persistent. Message-ID: <bug-258271-28929-CaPN3FZZlG@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-258271-28929@https.bugs.freebsd.org/bugzilla/> References: <bug-258271-28929@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258271 --- Comment #10 from Tomoaki AOKI <junchoon@dec.sakura.ne.jp> --- (In reply to Robert Clausecker from comment #8) Why I'm hesitating to use regular OSVERSION way here is because no commit f= or version bump mentions about mempcpy() addition. This can make confusion tracking changes in the future. Single bump for multiple commits is NOT AT ALL a problem, if the commit mes= sage lists all targetted commits, regardless they're related each other or not. If I'm not missing something, no bump mentions the commits adding mempcpy(). And for this case, checking for mempcpy() instead of checking for OSVERSION= has an advantage that no more update is needed when mempcpy() is added to branc= hes that doesn't have it currently. www/chromium is a huge port and changes without actual update would be bett= er minimized, I think. Anyway, Felix's latest patch looks fine enough for me. Thanks again, Felix! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-258271-28929-CaPN3FZZlG>