Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Dec 2018 06:44:33 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Johannes M Dieterich <jmd@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r487274 - head/graphics/drm-fbsd12.0-kmod
Message-ID:  <bm5m-hvpa-wny@FreeBSD.org>
In-Reply-To: <201812120223.wBC2NaiV060871@repo.freebsd.org> (Johannes M. Dieterich's message of "Wed, 12 Dec 2018 02:23:36 %2B0000 (UTC)")
References:  <201812120223.wBC2NaiV060871@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Johannes M Dieterich <jmd@FreeBSD.org> writes:

> Author: jmd
> Date: Wed Dec 12 02:23:35 2018
> New Revision: 487274
> URL: https://svnweb.freebsd.org/changeset/ports/487274
>
> Log:
>   graphics/drm-fbsd12.0: Update to 4.16 DRM
>   
>   Despite the improvements going from 4.11 to 4.16, it also
>   brings experimental support for i386 and powerpc64.
>   
>   Switch to dedicated upstream 12.0 branch
>   
>   Reviewed by:	zeising (x11)
>   Differential Revision:	https://reviews.freebsd.org/D18508

Fails to build on FreeBSD < 12. Did you forget to adjust OSVERSION check?

http://beefy9.nyi.freebsd.org/data/112amd64-default/487333/logs/drm-fbsd12.0-kmod-4.16.g20181210.log
http://beefy10.nyi.freebsd.org/data/112i386-default/487333/logs/drm-fbsd12.0-kmod-4.16.g20181210.log

Copying ${OSVERSION} < 1200067 from drm-current-kmod won't do as only
12.0-RELEASE appears to be supported. For one, r335018 snapshot fails:

In file included from include/drm/drmP.h:156:
include/drm/drm_file.h:376:1: error: unknown
      type name '__poll_t'; did you mean 'd_poll_t'?
__poll_t drm_poll(struct file *filp, struct poll_table_struct *wait);
^~~~~~~~
d_poll_t
sys/sys/conf.h:122:13: note: 'd_poll_t' declared here
typedef int d_poll_t(struct cdev *dev, int events, struct thread *td);
            ^
In file included from drivers/gpu/drm/ati_pcigart.c:35:
In file included from include/drm/drmP.h:156:
include/drm/drm_file.h:376:18: error:
      function cannot return function type 'd_poll_t' (aka 'int (struct cdev *, int, struct thread *)')
__poll_t drm_poll(struct file *filp, struct poll_table_struct *wait);
                 ^
2 errors generated.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bm5m-hvpa-wny>