From owner-freebsd-python@FreeBSD.ORG Fri Aug 8 17:51:10 2014 Return-Path: <owner-freebsd-python@FreeBSD.ORG> Delivered-To: freebsd-python@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 872581D1 for <freebsd-python@FreeBSD.org>; Fri, 8 Aug 2014 17:51:10 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5693622D7 for <freebsd-python@FreeBSD.org>; Fri, 8 Aug 2014 17:51:10 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s78HpAvt027927 for <freebsd-python@FreeBSD.org>; Fri, 8 Aug 2014 17:51:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-python@FreeBSD.org Subject: [Bug 192511] [patch] fix lang/python27 build with libressl Date: Fri, 08 Aug 2014 17:51:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: meyer.arne83@gmail.com X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-python@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: <bug-192511-17421-YgrLW2rCJt@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192511-17421@https.bugs.freebsd.org/bugzilla/> References: <bug-192511-17421@https.bugs.freebsd.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-python>, <mailto:freebsd-python-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python/> List-Post: <mailto:freebsd-python@freebsd.org> List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, <mailto:freebsd-python-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 08 Aug 2014 17:51:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192511 --- Comment #4 from meyer.arne83@gmail.com --- (In reply to Marcus von Appen from comment #3) > (In reply to meyer.arne83 from comment #2) > > (In reply to Marcus von Appen from comment #1) [...] > > > We need to get two things right: > > > > > > * handle OpenSSL support correctly and explicitly use OpenSSL, so that an > > > installed SSL replacement does not cause a wrong and unintended behaviour > > > * offer users to link against libressl explicitly (via an OPTION), which can > > > cause different behaviour. > > How about this: > > * Add smt. like WITH_OPENSSL_LIBRE and some logic to bsd.openssl.mk > > * Have the libressl port fail to build without that flag set. > > That sounds reasonable. I added the libressl maintainer and portmgr@ to this > issue to get their feedback on it. > I implemented the WITH_OPENSSL_LIBRE logic on my laptop. Tested it. Looks good so far. The only issue is: Are there ports who have a hard dependency on openssl/ports? > > * Add a static library or c file with dummy functions(RAND_egd, ...) to > > libressl. > > That might contradict the purpose of libressl and adds a can of worms (local > patches), which should be avoided. Best'd be to ask the upstream developers > of libressl about such things, I think. Yeah. You're right about that. I have a patch for libressl that adds back the RAND_egd api. But the functions just return -1 (means no connection to egd). As RAND_egd is the main reason for breakage, and basically useless, that seems like a tolerable approach to me. That way, we don't have to patch every user of that api. With that patch and the change to bsd.openssl.mk I can compile python27 without my first patch. I can open up a new bug with my patches, if anyone is interested... -- You are receiving this mail because: You are the assignee for the bug.