From owner-freebsd-hackers  Fri Feb 21 11:56:38 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id LAA17819
          for hackers-outgoing; Fri, 21 Feb 1997 11:56:38 -0800 (PST)
Received: from gvr.win.tue.nl (root@gvr.win.tue.nl [131.155.210.19])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id LAA17260;
          Fri, 21 Feb 1997 11:49:19 -0800 (PST)
Received: (from guido@localhost) by gvr.win.tue.nl (8.8.5/8.8.2) id UAA09374; Fri, 21 Feb 1997 20:47:45 +0100 (MET)
From: Guido van Rooij <guido@gvr.win.tue.nl>
Message-Id: <199702211947.UAA09374@gvr.win.tue.nl>
Subject: Re: hmm
In-Reply-To: <199702202322.PAA19571@flea.best.net> from Matt Dillon at "Feb 20, 97 03:22:27 pm"
To: dillon@best.net (Matt Dillon)
Date: Fri, 21 Feb 1997 20:47:45 +0100 (MET)
Cc: gurney_j@resnet.uoregon.edu, top@sonic.cris.net, audit-bin@FreeBSD.ORG,
        FreeBSD-hackers@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL28 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-hackers@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> :> > > underneath btw:
> :> > > 	if (*p != '\0' && p[strlen(p) - 1] == '[') {
> :> > > 	    ^^^^^^^^^^
> :Hmm...After rereading this, I think I have it wrong :-(). That's what you get
> :with quick answers. The check is indeed necessary.
> :
> :-Guido
> 
>     The check should probably be in there, but it not being there is not
>     likely to cause a security hole since page 0 is write-protected on FreeBSD
>     machines.

Nono, I didn;t mean the check for p==NULL or not; I meant the check
for p!="" (or equivalently: *p!='\0')

-Guido