From owner-p4-projects@FreeBSD.ORG  Fri Feb 15 06:32:41 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9A56B16A46C; Fri, 15 Feb 2008 06:32:41 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5D11916A41A;
	Fri, 15 Feb 2008 06:32:41 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 2588113C442;
	Fri, 15 Feb 2008 06:32:40 +0000 (UTC) (envelope-from sam@errno.com)
Received: from Macintosh-2.local ([10.0.0.196]) (authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m1F6WeHW013489
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 14 Feb 2008 22:32:40 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <47B53208.5080205@errno.com>
Date: Thu, 14 Feb 2008 22:32:40 -0800
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
MIME-Version: 1.0
To: Kevin Lo <kevlo@freebsd.org>
References: <200802150546.m1F5kGTc005452@repoman.freebsd.org>
	<1203055151.6252.2.camel@monet>
In-Reply-To: <1203055151.6252.2.camel@monet>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC--Metrics: ebb.errno.com; whitelist
Cc: Sepherosa Ziehau <sephe@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 135425 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Feb 2008 06:32:41 -0000

Kevin Lo wrote:
> Sepherosa Ziehau wrote:
>> http://perforce.freebsd.org/chv.cgi?CH=135425
>>
>> Change 135425 by sephe@sephe_zealot:sam_wifi on 2008/02/15 05:45:20
>>
>> 	Revert previous two changes.
>>
>> Affected files ...
>>
>> .. //depot/projects/wifi/sys/dev/bwi/if_bwi.c#17 edit
>> .. //depot/projects/wifi/sys/dev/bwi/if_bwi_pci.c#6 edit
> 
> Is there anything wrong with loading bwi_v3 firmware module?
> 
> 	Kevin
> 
> 

Using a module dependency to load the means firmware_get doesn't get 
chance to do it as was intended.  I think the problem is really that we 
need to fixup naming of bwi_v3.ko so the driver can locate it--either by 
changing the name requested in the first firmware_get or possibly by 
adding a symlink to the .ko.

	Sam