From owner-svn-src-head@FreeBSD.ORG  Wed Oct  1 20:33:32 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4F3852DC
 for <svn-src-head@freebsd.org>; Wed,  1 Oct 2014 20:33:32 +0000 (UTC)
Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com
 [209.85.192.50])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0CB68303
 for <svn-src-head@freebsd.org>; Wed,  1 Oct 2014 20:33:31 +0000 (UTC)
Received: by mail-qg0-f50.google.com with SMTP id q108so836742qgd.23
 for <svn-src-head@freebsd.org>; Wed, 01 Oct 2014 13:33:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=6A8bZeX4025K5YBj1l1gy/z+RwFBe2d95rsvBDhyIRw=;
 b=LUY2x/npuhHJy2i6EroIb1I9uruRzzq0Ydn3cK0K5ET01Q0RSgSQol+8fTmoDa0opE
 WRornj4L4W9tZK08Yi5GAzHhA2uHQrsxl/yi/DS04PB4kFmP8cB9rWIn+k9NJh65UeDp
 Xc7tcFNfGEqA0jdMZ9BH5rxyHO0/kn7GsERyABM8F5NvfMEqGUq6C0iEwRcFJaDNdgva
 lzTpym+w2zOJ4qvAymeTWxY5YI+IFOzX2zpEnESfNuquShVh9K2c+9dcvHf2oKMkrQtr
 zWOo8QEifI8vIn4bqL9TWsJ4m2tfKPjXg0vjCIB093tWPItduOl7wBdT0Ntsq0fHhqGX
 ADwg==
X-Gm-Message-State: ALoCoQl2b/qoaQhfqedmSB3hvUj39+72Hiv7CVvUEdHh+ReBT23MrxuDovgUjaGnWfJ4jwKjMB07
MIME-Version: 1.0
X-Received: by 10.224.32.138 with SMTP id c10mr67036630qad.1.1412195610628;
 Wed, 01 Oct 2014 13:33:30 -0700 (PDT)
Received: by 10.140.31.36 with HTTP; Wed, 1 Oct 2014 13:33:30 -0700 (PDT)
In-Reply-To: <542C6087.2060909@FreeBSD.org>
References: <201409291505.s8TF5Nhh066884@svn.freebsd.org>
 <542C14F6.7020506@FreeBSD.org>
 <CADBaqmgnJzrev_cYaJyXABABp5b0y7=5cGFDc1oovgs=-jRVyg@mail.gmail.com>
 <542C4FEC.8010800@FreeBSD.org>
 <CADBaqmjz1aCQhQa5YMNym78jnBhiQ=Etjz1W5Hc6nOe=MygQFA@mail.gmail.com>
 <542C6087.2060909@FreeBSD.org>
Date: Wed, 1 Oct 2014 14:33:30 -0600
Message-ID: <CADBaqmiBH1L2Q2eRdovSFS6JKQWkvM6u3DTAAWmZ9Ka4ynxaZw@mail.gmail.com>
Subject: Re: svn commit: r272282 - head/share/mk
From: Will Andrews <will@firepipe.net>
To: Jung-uk Kim <jkim@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: Baptiste Daroussin <bapt@freebsd.org>,
 "src-committers@FreeBSD.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 Bryan Drewery <bdrewery@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 Guido Falsi <madpilot@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Oct 2014 20:33:32 -0000

On Wed, Oct 1, 2014 at 2:13 PM, Jung-uk Kim <jkim@freebsd.org> wrote:
> Actually, portmaster.diff is just enough to fix portmaster problem.
> ports.diff is for consistency.

So I guess portmaster is doing a string comparison to decide whether
to install a port?  That sounds like a bug in portmaster.  I suggest
changing it to always ask make for the value of PORTSDIR.

--Will.