From owner-svn-src-head@freebsd.org Tue Feb 28 21:32:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39109CF2833; Tue, 28 Feb 2017 21:32:52 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-wr0-x236.google.com (mail-wr0-x236.google.com [IPv6:2a00:1450:400c:c0c::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E50B4D03; Tue, 28 Feb 2017 21:32:51 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-wr0-x236.google.com with SMTP id u48so17561859wrc.0; Tue, 28 Feb 2017 13:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IEm+IZjSqj9pSDQK3T1C55pkV5KO9nal4pvg6Zm9FWI=; b=cTipb+CW2fQunVFrDolzk1hkU387WzDIOMXnSK2p7wa6agc5pAeXLJZy0/5CAym8kY q5PSPLdZL79bNu8SmwHGy4BbzhuYHqvnr2zOAkXMg6DzS3QygM6yD7unvGg6bAmBt4qV KbOwbVmZ72x8vZv1ahR20hJLaviUZ4FDwaN6Gx/7ecnV113D4DV2PFAILO/EbnCXIhIV WLiwL8wKBAzqlN73Kk4+YoL3hSOR82znY6aoeR8aTVMU3Q2f0370vcPA5TNjRiqHT4sD 5CCqVafbx9+13QWQ2Nl6ajt7q8zjhIoN0642IawcvBI57vwTb5Cv6JDY8rIyft2xBw66 XqIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IEm+IZjSqj9pSDQK3T1C55pkV5KO9nal4pvg6Zm9FWI=; b=eEuJ3FO3zbzA8lzJxysGeoH06cULf4k95374oZrhSeQoC1nTSBL+dkO4N12/QIQ3k4 k5FObzXgUQg+TFnlGsbvqLe1sWXeW/KOqlSLzTysirDnTEKOh/urP2PK9QUZ80U8pNNZ g+Uy3AYGuOpiWWGznlztTE2ORwqtaeu0Sbvbb1xYqm9m6ovpOK9nGkdnP/jcwucGJYHI nFnON7Ijw62Wgyk4qE4hXm5RFD9EP1JVhhJ8snqnWetDS4DXdWGoLh7SgNcjyjs1L+Xi +aacMeD6h+PrN/J/dtr9pLRHN2hfiOSKdMgQHjGao6Um0mlQv4XTMtKkqjuErSCPudcN dWPg== X-Gm-Message-State: AMke39lVAFiw7CH7KeCeDCvneHSv20avwGZb39zv0Q5xHjCK0UJc/oQCFghHrxlWC+7ZmstTRJJeZ9zTPucoVg== X-Received: by 10.223.133.205 with SMTP id 13mr4436112wru.1.1488317570147; Tue, 28 Feb 2017 13:32:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.195.3 with HTTP; Tue, 28 Feb 2017 13:32:49 -0800 (PST) In-Reply-To: <20170228213044.GK1044@FreeBSD.org> References: <201702280514.v1S5EhPq060885@repo.freebsd.org> <1969312.3TTRqhLH9r@ralph.baldwin.cx> <20170228193605.GJ1044@FreeBSD.org> <20170228213044.GK1044@FreeBSD.org> From: Benjamin Kaduk Date: Tue, 28 Feb 2017 15:32:49 -0600 Message-ID: Subject: Re: svn commit: r314373 - in head: . etc/defaults etc/rc.d lib/libc/regex share/man/man4/man4.i386 share/man/man5 sys/amd64/conf sys/boot/forth sys/compat/svr4 sys/conf sys/dev/streams sys/i386/conf sy... To: Gleb Smirnoff Cc: Ravi Pokala , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , John Baldwin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 21:32:52 -0000 On Tue, Feb 28, 2017 at 3:30 PM, Gleb Smirnoff wrote: > On Tue, Feb 28, 2017 at 01:39:12PM -0600, Benjamin Kaduk wrote: > B> > I don't think this deserves UPDATING entry, since it doesn't require > B> > any action from a person who updates from sources. > B> > > B> > I don't think this requires __FreeBSD_version bump, since the latter > B> > is used to assist compilation of open source application that use > B> > changed API. The change removed support to run binaries. > B> > > B> > B> That is not the only use of __FreeBSD_version, which is (at least) > exposed > B> to the ports collection and can cause conditional changes in what are > B> shipped by ports. > B> Which is not to say that any current ports ship affected binaries, of > B> course, but just to point out that the scope of the symbol is broader > than > B> stated. > > How can I check the __FreeBSD_version in a port Makefile? My understanding > is that there is no standard way for such thing. Of course I can parse > /usr/include/sys/param.h... > > My understanding is that the constant is for sources only: > > https://www.freebsd.org/doc/en/books/porters-handbook/ > porting-versions.html > > Look for OSVERSION in /usr/ports/Mk/bsd.port.mk -Ben