From owner-svn-src-all@freebsd.org Tue May 12 04:27:32 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9C9DA2E213F; Tue, 12 May 2020 04:27:32 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49LlC75llBz3C52; Tue, 12 May 2020 04:27:31 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f66.google.com with SMTP id j4so9456785otr.11; Mon, 11 May 2020 21:27:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=Y8wmSmT7IzBn/yA6y4+odeva8sHFRlfa0jeKDf4Qfmg=; b=Phbe/CQahev7bSphM/lXoNXVu8qwvoMPyzRw2jreEBDPJPh2nqTyj65GO32kq1TlgU FePWzyQjkb0q/aGj9NPbbSkq5O9OV1Z+WKt9LdUdo3DdJ8y64psKdqrwN3VoFEi2503p cNHT4kL//EFmR8XxXqHbkA9yWAt93tpvO7M/8DcOOOPHYZ8WZKJ9Q7z9UNzZNNSUhLfn Xt4FA/OO0drPBArzzzCN1IAYVL47+GuK+aF1iUkbGuBSuKsiv8HJ1S9Zd+kbFBBrrXF+ BbKRbh6QBHNO5HqvnUVJ/dE0LCXSStr7/eSo067NMifXqyVVkb6U+YhOkmiXPkNo32qA CQKw== X-Gm-Message-State: AGi0PuYjdbSktXo7ul14SWjJBoIVem2UlxC5R5X8mitErhlq+fSD7QKk zVToPphYTI/QQulB/ob5h2kk/QQs X-Google-Smtp-Source: APiQypInXSBG0jkZNpRdlTrgfl6u7arW+JA+/tgWszzfrDKZOjHslWzEvQzqkaxCQDJ9JZ/Esr+y+g== X-Received: by 2002:a9d:7a6:: with SMTP id 35mr13822451oto.201.1589257650038; Mon, 11 May 2020 21:27:30 -0700 (PDT) Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com. [209.85.167.170]) by smtp.gmail.com with ESMTPSA id m16sm3333907oop.40.2020.05.11.21.27.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2020 21:27:29 -0700 (PDT) Received: by mail-oi1-f170.google.com with SMTP id c12so16152930oic.1; Mon, 11 May 2020 21:27:29 -0700 (PDT) X-Received: by 2002:aca:4ac3:: with SMTP id x186mr13398030oia.81.1589257649452; Mon, 11 May 2020 21:27:29 -0700 (PDT) MIME-Version: 1.0 References: <202005112257.04BMvMx2096445@repo.freebsd.org> <202005120328.04C3SR2X081094@slippy.cwsent.com> In-Reply-To: <202005120328.04C3SR2X081094@slippy.cwsent.com> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Mon, 11 May 2020 21:27:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r360944 - in head: sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/fs/fuse sys/fs/unionfs sys/i386/i386 sys/kern sys/mips/mips sys/powerpc/powerpc sys/riscv/riscv sys/sys tools/coccinelle To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 49LlC75llBz3C52 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.210.66 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-2.18 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[66.210.85.209.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_GOOD(0.00)[66.210.85.209.rep.mailspike.net : 127.0.0.18]; HAS_REPLYTO(0.00)[cem@freebsd.org]; IP_SCORE(-0.18)[ip: (-0.03), ipnet: 209.85.128.0/17(-0.39), asn: 15169(-0.42), country: US(-0.05)]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 04:27:32 -0000 Thanks Cy. I=E2=80=99ll revert it when I=E2=80=99m back at a computer. Best, Conrad On Mon, May 11, 2020 at 20:28 Cy Schubert wrote= : > In message <202005112257.04BMvMx2096445@repo.freebsd.org>, Conrad Meyer > writes: > > Author: cem > > Date: Mon May 11 22:57:21 2020 > > New Revision: 360944 > > URL: https://svnweb.freebsd.org/changeset/base/360944 > > > > Log: > > copystr(9): Move to deprecate [2/2] > > > > Unlike the other copy*() functions, it does not serve to copy from on= e > > address space to another or protect against potential faults. It's > just > > an older incarnation of the now-more-common strlcpy(). > > > > Add a coccinelle script to tools/ which can be used to mechanically > > convert existing instances where replacement with strlcpy is trivial. > > In the two cases which matched, fuse_vfsops.c and union_vfsops.c, the > > code was further refactored manually to simplify. > > > > Replace the declaration of copystr() in systm.h with a small macro > > wrapper around strlcpy. > > > > Remove N redundant MI implementations of copystr. For MIPS, this > > entailed inlining the assembler copystr into the only consumer, > > copyinstr, and making the latter a leaf function. > > > > Reviewed by: jhb > > Differential Revision: https://reviews.freebsd.org/D24672 > > > > Added: > > head/tools/coccinelle/ > > head/tools/coccinelle/copystr9.cocci (contents, props changed) > > Deleted: > > head/sys/arm64/arm64/copystr.c > > head/sys/powerpc/powerpc/copystr.c > > head/sys/riscv/riscv/copystr.c > > Modified: > > head/sys/amd64/amd64/support.S > > head/sys/arm/arm/copystr.S > > head/sys/fs/fuse/fuse_vfsops.c > > head/sys/fs/unionfs/union_vfsops.c > > head/sys/i386/i386/support.s > > head/sys/kern/subr_csan.c > > head/sys/mips/mips/support.S > > head/sys/sys/systm.h > > > > Hi Conrad, > > This is causing a failure to boot with geom_mirror: > > GEOM_MIRROR: Device mirror/gm0 launched (2/2). > GEOM_MIRROR: Device mirror/gm1 launched (2/2). > GEOM_MIRROR: Device mirror/gm2 launched (2/2). > GEOM_MIRROR: Device mirror/gm3 launched (2/2). > mountroot: waiting for device /dev/mirror/gm0a... > Mounting from ufs:/dev/mirror/gm0a failed with error 2; retrying for 3 > more > seconds > exec /sbin/init: error 20 > exec /sbin/init.bak: error 20 > exec /rescue/init: error 20 > init: not found in path /sbin/init:/sbin/oinit:/sbin/init.bak:/rescue/ini= t > panic: no init > cpuid =3D 1 > time =3D 1589225852 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe004df51ba0 > vpanic() at vpanic+0x182/frame 0xfffffe004df51bf0 > panic() at panic+0x43/frame 0xfffffe004df51c50 > start_init() at start_init+0x23c/frame 0xfffffe004df51cf0 > fork_exit() at fork_exit+0x7e/frame 0xfffffe004df51d30 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe004df51d30 > --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- > Uptime: 9s > acpi0: reset failed - timeout > Automatic reboot in 15 seconds - press a key on the console to abort > --> Press a key on the console to reboot, > --> or switch off the system now. > Rebooting... > cpu_reset: Restarting BSP > cpu_reset_proxy: Stopped CPU 1 > > > Anticipating you might ask if r360941 is the problem. It is not. Revertin= g > this r360944 (not r360941) resolves the boot problem. System is amd64. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > The need of the many outweighs the greed of the few. > > >