Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 04 Sep 2019 11:59:04 +0000
From:      Poul-Henning Kamp <phk@phk.freebsd.dk>
To:        current@freebsd.org
Subject:   Weird goings on with make::empty()
Message-ID:  <3843.1567598344@critter.freebsd.dk>
next in thread | raw e-mail | index | archive | help 
On:

	Repository Root: svn+ssh://repo.freebsd.org/base
	Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
	Revision: 351809

I built a kernel, but drm-current-kmod did not get compiled
from the new world order in /usr/local/sys/modules

Debugging I ended up doing this to src/sys/conf/kern.post.mk:

	Index: sys/conf/kern.post.mk
	=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
	--- sys/conf/kern.post.mk	(revision 351809)
	+++ sys/conf/kern.post.mk	(working copy)
	@@ -77,12 +77,14 @@
		    ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
	 .endif
	 .for module in ${LOCAL_MODULES}
	-.if !empty(module)
	+	true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4 ${MODULES_WIT=
H_WORLD}"
	+#.if !empty(module)
	+	true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4 ${MODULES_WIT=
H_WORLD}"
		@${ECHODIR} "=3D=3D=3D> ${module} (${target:S/^reinstall$/install/:S/^cl=
obber$/cleandir/})"
		@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
		    DIRPRFX=3D"${module}/" \
		    ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
	-.endif
	+#.endif
	 .endfor
	 .endif
	 .endfor

This gives me the expected output from buildkernel:

	true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
	true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "

If I leave in the ".if !empty(module)" line in, I only get:

	true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "

suggestions welcome...


-- =

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence=
.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3843.1567598344>