From owner-cvs-src-old@FreeBSD.ORG Fri Jan 22 21:23:45 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1189C106568B for ; Fri, 22 Jan 2010 21:23:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F33818FC17 for ; Fri, 22 Jan 2010 21:23:44 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o0MLNiR9019818 for ; Fri, 22 Jan 2010 21:23:44 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o0MLNikM019817 for cvs-src-old@freebsd.org; Fri, 22 Jan 2010 21:23:44 GMT (envelope-from jhb@repoman.freebsd.org) Message-Id: <201001222123.o0MLNikM019817@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jhb@repoman.freebsd.org using -f From: John Baldwin Date: Fri, 22 Jan 2010 21:23:09 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_7 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2010 21:23:45 -0000 jhb 2010-01-22 21:23:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: SVN rev 202837 on 2010-01-22 21:23:09Z by jhb MFC 189698,192035: Optimize the inner loop of pmap_copy(). Correct a rare use-after-free error in pmap_copy(). This error was introduced in amd64 revision 1.540 and i386 revision 1.547. However, it had no harmful effects until after a recent change, r189698, on amd64. (In other words, the error is harmless in RELENG_7.) The error is triggered by the failure to allocate a pv entry for the one and only mapping in a page table page. I am addressing the error by changing pmap_copy() to abort if either pv entry allocation or page table page allocation fails. This is appropriate because the creation of mappings by pmap_copy() is optional. They are a (possible) optimization, and not a requirement. Correct a nearby whitespace error in the i386 pmap_copy(). Revision Changes Path 1.590.2.31 +9 -4 src/sys/amd64/amd64/pmap.c 1.594.2.25 +4 -2 src/sys/i386/i386/pmap.c