From owner-svn-src-all@FreeBSD.ORG  Tue May  3 12:21:08 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E25C4106579F;
	Tue,  3 May 2011 12:21:08 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id B585F8FC15;
	Tue,  3 May 2011 12:21:08 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 5AC8B46B52;
	Tue,  3 May 2011 08:21:08 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id E9DAB8A027;
	Tue,  3 May 2011 08:21:07 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Craig Rodrigues <rodrigc@freebsd.org>
Date: Tue, 3 May 2011 07:50:44 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; )
References: <201105030743.p437hl8M075368@svn.freebsd.org>
In-Reply-To: <201105030743.p437hl8M075368@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201105030750.44240.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Tue, 03 May 2011 08:21:08 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r221365 - head/lib/libstand
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2011 12:21:09 -0000

On Tuesday, May 03, 2011 3:43:47 am Craig Rodrigues wrote:
> Author: rodrigc
> Date: Tue May  3 07:43:47 2011
> New Revision: 221365
> URL: http://svn.freebsd.org/changeset/base/221365
> 
> Log:
>   - Comment out unused variable.
>   - Add parentheses around expression to eliminate compiler warning.
> 
> Modified:
>   head/lib/libstand/dosfs.c
> 
> Modified: head/lib/libstand/dosfs.c
> 
==============================================================================
> --- head/lib/libstand/dosfs.c	Tue May  3 07:39:54 2011	(r221364)
> +++ head/lib/libstand/dosfs.c	Tue May  3 07:43:47 2011	(r221365)
> @@ -358,7 +358,7 @@ dos_stat(struct open_file *fd, struct st
>  static int
>  dos_readdir(struct open_file *fd, struct dirent *d)
>  {
> -    DOS_FILE *f = (DOS_FILE *)fd->f_fsdata;
> +    /* DOS_FILE *f = (DOS_FILE *)fd->f_fsdata; */

Err, wouldn't it be better to just remove it if it is unused?

-- 
John Baldwin