Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Jan 2012 18:26:56 +0000 (UTC)
From:      Peter Wemm <peter@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r230311 - head/lib/libpam/modules/pam_unix
Message-ID:  <201201181826.q0IIQuLX051824@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: peter
Date: Wed Jan 18 18:26:56 2012
New Revision: 230311
URL: http://svn.freebsd.org/changeset/base/230311

Log:
  Rev 228065 (change bsd.own.mk -> bsd.init.mk) broke pam_unix.so by causing
  the LDADD/DPADD to lose the -lpam, and causing openpam_dynamic() to fail
  due to "openpam_get_options" being undefined.
  
  This would cause obscure console log messages like:
    openpam_dynamic(): No error: 0
    openpam_load_module(): no pam_unix.so found
  and other helpful messages which are no help in diagnosing the problem.
  
  Fortunately this change was not mfc'ed to 9.x, it isn't broken there.

Modified:
  head/lib/libpam/modules/pam_unix/Makefile

Modified: head/lib/libpam/modules/pam_unix/Makefile
==============================================================================
--- head/lib/libpam/modules/pam_unix/Makefile	Wed Jan 18 18:22:25 2012	(r230310)
+++ head/lib/libpam/modules/pam_unix/Makefile	Wed Jan 18 18:26:56 2012	(r230311)
@@ -40,8 +40,8 @@ LIB=	pam_unix
 SRCS=	pam_unix.c
 MAN=	pam_unix.8
 
-DPADD= ${LIBUTIL} ${LIBCRYPT}
-LDADD= -lutil -lcrypt
+DPADD+= ${LIBUTIL} ${LIBCRYPT}
+LDADD+= -lutil -lcrypt
 
 .if ${MK_NIS} != "no"
 CFLAGS+= -DYP



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201181826.q0IIQuLX051824>