From owner-freebsd-ports@FreeBSD.ORG Thu Nov 13 07:28:45 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EA5116A4CE; Thu, 13 Nov 2003 07:28:45 -0800 (PST) Received: from mx1.fillmore-labs.com (nuuk.fillmore-labs.com [62.138.193.82]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A4E343FB1; Thu, 13 Nov 2003 07:28:43 -0800 (PST) (envelope-from eikemeier@fillmore-labs.com) Received: from root by mx1.fillmore-labs.com with local-bsmtp (Exim 4.24; FreeBSD 4.9) id 1AKJNG-000Aew-VP; Thu, 13 Nov 2003 16:27:10 +0100 Message-ID: <3FB39FB5.5000209@fillmore-labs.com> Date: Thu, 13 Nov 2003 16:13:57 +0100 From: Oliver Eikemeier To: FreeBSD-gnats-submit@FreeBSD.org User-Agent: KMail/1.5.9 Organization: Fillmore Labs GmbH X-Complaints-To: abuse@fillmore-labs.com cc: ports@FreeBSD.org Subject: ports/59254: ports that write something after bsd.port.mk X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2003 15:28:45 -0000 >Number: 59254 >Category: ports >Originator: Oliver Eikemeier >Organization: Fillmore Labs - http://www.fillmore-labs.com >Synopsis: ports that write something after bsd.port.mk >Severity: non-critical >Priority: medium >Category: ports >Class: sw-bug >Release: FreeBSD 5.1-CURRENT i386 >Environment: System: FreeBSD nuuk.fillmore-labs.com 5.1-CURRENT >Description: Dear port maintainers, included is a list of ports that write something after .include .include .include "${MASTERDIR}/Makefile" or set MASTERDIR without being a slave port. These are detected by version 2.4.8 of port devel/portlint, you can find referencs in the FreeBSD Porter's Handbook at: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-after-port-mk.html http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-masterdir.html In most cases this is an attempt to work around the structure of bsd.port.mk. Even though this may be an easy solution for the needs of your port, please think about an other way to do it. Essentially all tools that work on the whole ports tree assume a certain uniformity in ports Makefiles, which goes beyond just compiling and installing without errors. Non-adherence to standards makes it hard for people dealing with the ports tree as a whole, and hinders progress because small changes in bsd.port.mk may break your port. If you do not know how to fix the port, ask at ports@FreeBSD.org or don't hesitate to contact me. If there is currently no other way to do what you need for installing the port, this is an area where the bsd.port.mk has to be improved, and it is important that we get aware of this fact. When there are only some comment lines at the end of the Makefile, please move or delete them. There is not FreeBSD standard that recommends ending a Makefile with '#EOF', and if not all ports do this it is of no use. I'm sorry if it hit some of Alan's ports with that, no disrespect intended. Please excuse the inconvenience -Oliver >Fix: clive@FreeBSD.org - chinese/bitchx - chinese/mutt dinoex@FreeBSD.org - mail/sendmail don@na.rim.or.jp - japanese/ruby-ming eric@fractal.csie.org - chinese/links fjoe@freebsd.org - databases/p5-DBD-Pg girgen@pingpong.net - databases/postgresql7 gnome@FreeBSD.org - mail/mozilla-thunderbird - www/mozilla-firebird honda@kashio.info.mie-u.ac.jp - japanese/ng-canna jb.quenot@caraldi.com - www/resin2 - www/resin3 jeh@FreeBSD.org - devel/arm-rtems-binutils - devel/arm-rtems-g77 - devel/arm-rtems-gcc - devel/arm-rtems-gcj - devel/arm-rtems-gdb - devel/arm-rtems-objc - devel/i386-rtems-binutils - devel/i386-rtems-g77 - devel/i386-rtems-gcc - devel/i386-rtems-gcj - devel/i386-rtems-gdb - devel/i386-rtems-objc - devel/i960-rtems-binutils - devel/i960-rtems-gcc - devel/i960-rtems-gdb - devel/m68k-rtems-binutils - devel/m68k-rtems-g77 - devel/m68k-rtems-gcc - devel/m68k-rtems-gcj - devel/m68k-rtems-gdb - devel/m68k-rtems-objc - devel/mips-rtems-binutils - devel/mips-rtems-g77 - devel/mips-rtems-gcc - devel/mips-rtems-gcj - devel/mips-rtems-gdb - devel/mips-rtems-objc - devel/powerpc-rtems-binutils - devel/powerpc-rtems-g77 - devel/powerpc-rtems-gcc - devel/powerpc-rtems-gcj - devel/powerpc-rtems-gdb - devel/powerpc-rtems-objc - devel/sh-rtems-binutils - devel/sh-rtems-g77 - devel/sh-rtems-gcc - devel/sh-rtems-gcj - devel/sh-rtems-gdb - devel/sh-rtems-objc - devel/sparc-rtems-binutils - devel/sparc-rtems-g77 - devel/sparc-rtems-gcc - devel/sparc-rtems-gcj - devel/sparc-rtems-gdb - devel/sparc-rtems-objc jihuang@gate.sinica.edu.tw - chinese/bind8 kde@freebsd.org - devel/qt-designer - devel/tinyq knu@FreeBSD.org - japanese/ruby-romkan lioux@FreeBSD.org - mail/qmail - sysutils/clockspeed maho@FreeBSD.org - math/spooles-mpich - science/mpqc-mpich mi@aldan.algebra.com - devel/tkp4 mita@FreeBSD.org - japanese/ghostscript-gnu-jpnfont - korean/ghostscript-gnu-korfont nadav@cs.technion.ac.il - hebrew/pine obrien@FreeBSD.org - shells/bash2 - vietnamese/unicode-uhoai openoffice@FreeBSD.org - portuguese/ooodict-pt_BR - portuguese/ooodict-pt_PT orlando.bassotto@ieo-research.it - emulators/vmware3 ports@FreeBSD.org - audio/ermixer - databases/pydbdesigner - devel/cdialog - devel/invitation_to_ruby - devel/ossp-al - devel/ossp-cfg - devel/ossp-ex - devel/ossp-l2 - devel/ossp-val - devel/ossp-var - devel/ruby-jttui - graphics/mgp-gallery - japanese/xvi-euc - japanese/xvi-sjis - net/ossp-sa - print/cups - print/cups-base - print/cups-lpr - sysutils/xstow - www/lynx-ssl sada@FreeBSD.org - japanese/p5-manual statue@freebsd.sinica.edu.tw - chinese/dictd taguchi@tohoku.iij.ad.jp - x11-servers/XttXF86srv-common tmutoh@mx10.freecom.ne.jp - japanese/ical trevor@FreeBSD.org - audio/linux-mbrola vanilla@FreeBSD.org - chinese/irssi yatt@luna2.org - audio/timidity++-emacs yssu@CCCA.NCTU.edu.tw - chinese/tin