From nobody Thu Sep 4 14:14:02 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cHhL34wpvz6667Q; Thu, 04 Sep 2025 14:14:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cHhL34Mr5z3bvK; Thu, 04 Sep 2025 14:14:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756995243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8cl38QZU2+nyHOR7l5BKyjeTlCcAbx83Y5BcBveykE=; b=yXw9fBL/wBL4MVOtNGiyBHJ5n73as+/MIiBzgV8I3URm4z7rqp45ynZeeZ/9nOap7Xursf uirWUf1XQ6iPhlVSNPoz5MTHr1Y7qAl/gtHLt/p6Rvb4jZlE6+4EZxRQH0P4okYl2+CeJN yXmfqoRozo3H+jbbaLvtSGvTNu3GZuyYXBeKdxopf67NVD23nw6vPy9iALKCV5YIFkyl4u pXe0RFMeGymFV659I9BRS83OAcREUdmvCmXcXt8tkil+sEfBzetJP7I3q5cZaw5GYkKpBM L0VzK1G/NfxCcCtjV6Jz3bbKCWF7iHYzfpwkzmTEn30bdDSDSOFcb7nv6zAYTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756995243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8cl38QZU2+nyHOR7l5BKyjeTlCcAbx83Y5BcBveykE=; b=qRndhI8ne2/1n3vj7oUSUZ1fFnIV8IKsreUnDi28Ck1d1mKZkRthlybBY2VViifroiPbhu 7o6feWaoBfOxQWVsRjipbtj4koh5/AM6EDC+Toy279UPMsOp9RTOJknAwlAP7lcL4thZSb FQUQHLGPtoi86bDHaeKhWkNVWHMfpERmRIbpv9Vdqz0pqq/knnXMJdiRIwJIhVHErQOTIN cKC908tJuFCBXSzY/bQ7HHOUASpiL65W3xnFNUXm6SpgImA63wlF4IzMa9d1JIZ/cENL7d r0c+7mR2YcyzicQ7sIurN5XhHUeIxhS5A+bXOHlnnWZBzqd7hCnUeFZEDI0yMg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756995243; a=rsa-sha256; cv=none; b=DIyLCKK8QFH5IwiXlfGEkGhUKO6JdZte4hXHueVu/lJT7G/tjxnh1+EkQbjHoYAdMfQUBP JItOawriAq8YMkQYghF2od0+ZVsS7S55eSWLhPOLmaewRW7UVAT/GcJrTEwi8AAPgN8d8/ CWFYMm4T8mqtlP0TmWwP6rz4lZI7swRkGNPdZcK0IRROBo9kgM4tci5czZeXzAhyXlIr8n 9TJ0W0jNnnYyMXUh9blg7Jq0eudjAvWx0LFwWHX9Jnfo9ql3OpWYkUsFx2io8rSszFMAgc ZnDLiaCsS/UUwHj6npR9sOdiIo6hH8urwmBBa7jlbYexJEm7GhP6WW6+72fMBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4202:5670:343b:392c:5012:89d2] (unknown [IPv6:2601:5c0:4202:5670:343b:392c:5012:89d2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cHhL32R9DzD3g; Thu, 04 Sep 2025 14:14:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Thu, 4 Sep 2025 10:14:02 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 9404c479946c - main - pci_user: Report NUMA domain Content-Language: en-US To: Jake Freeland , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202509040245.5842jXvV085511@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202509040245.5842jXvV085511@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/3/25 22:45, Jake Freeland wrote: > The branch main has been updated by jfree: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9404c479946c00b6ac94253d2037c47251dc606c > > commit 9404c479946c00b6ac94253d2037c47251dc606c > Author: Jake Freeland > AuthorDate: 2025-09-04 02:42:23 +0000 > Commit: Jake Freeland > CommitDate: 2025-09-04 02:42:23 +0000 > > pci_user: Report NUMA domain > > A PCI device's NUMA domain is now accessible via the pd_numa_domain > member of struct pci_conf when using the PCIOCGETCONF ioctl. > > A new ioctl number has been assigned to PCIOCGETCONF to preserve > compatibility with binaries compiled on FreeBSD versions 7 through 14. > Such binaries can continue to use the PCIOCGETCONF ioctl number > that they were compiled with and experience no ABI repercussions. > > Reviewed by: imp, markj > Differential Revision: https://reviews.freebsd.org/D44289 For future reference: you didn't need to bump to a new number for the ioctl since the size of the argument is encoded in the ioctl as well. This feature of ioctls also means that we generally don't add padding (as you did in the followup commit) as you will naturally get a new ioctl cmd value anytime you add more fields in the future. This avoids the one point Warner raised in the review about how do you define the semantics of the padding as that approach defers reserving space in the structure until the semantics of that space is known. -- John Baldwin