Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Oct 2012 13:20:24 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Maksim Yevmenkin <emax@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r241616 - in head/sys: dev/ixgbe net
Message-ID:  <201210171320.24557.jhb@freebsd.org>
In-Reply-To: <CAFPOs6rVjFqh4FxfSt_yhzUGvgiVQkmpP6Lbgyckz6X7Y96RQQ@mail.gmail.com>
References:  <201210162018.q9GKIG9q013028@svn.freebsd.org> <201210170951.23800.jhb@freebsd.org> <CAFPOs6rVjFqh4FxfSt_yhzUGvgiVQkmpP6Lbgyckz6X7Y96RQQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, October 17, 2012 11:26:21 am Maksim Yevmenkin wrote:
> On Wed, Oct 17, 2012 at 6:51 AM, John Baldwin <jhb@freebsd.org> wrote:
> 
> [...]
> 
> >> > Maybe a helper 'if_set_baudrate(ifp, IF_Gbps(10))' that would DTRT.
> >> > (It could be a static inline or some such).  I would just like to
> >> > keep the readability.
> >>
> >> well, yes, i thought about it, but decided not to do it right away. we
> >> could provide shortcuts/macros for "popular" baudrates, i.e. 1, 10, 40
> >> and 100 Gbps. while ixgbe(4) example is not ideal, i thought it still
> >> was pretty readable :)
> >
> > I don't really find it all that readable.  IF_Gbps(1) looks like a typo
> > to a casual reader.  I really think you should have something like:
> 
> [...]
> 
> very well :)  would something like (please see below) work?

Looks good to me.  Thank you. :)

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210171320.24557.jhb>