From owner-freebsd-bugs@freebsd.org Mon Feb 22 14:58:45 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1CB99541724 for ; Mon, 22 Feb 2021 14:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DklgT09BFz3lSB for ; Mon, 22 Feb 2021 14:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 025B4541471; Mon, 22 Feb 2021 14:58:45 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0223F54181C for ; Mon, 22 Feb 2021 14:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DklgS6dCfz3lFL for ; Mon, 22 Feb 2021 14:58:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D6CE0276CC for ; Mon, 22 Feb 2021 14:58:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11MEwiWm092954 for ; Mon, 22 Feb 2021 14:58:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11MEwiUm092953 for bugs@FreeBSD.org; Mon, 22 Feb 2021 14:58:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 253764] mkimg does not allocate space for partitions when given an absolute offset Date: Mon, 22 Feb 2021 14:58:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.4-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ardovm@yahoo.it X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 14:58:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253764 Bug ID: 253764 Summary: mkimg does not allocate space for partitions when given an absolute offset Product: Base System Version: 11.4-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: ardovm@yahoo.it When mkimg(1) is asked to output a partition of a given size with a given absolute offset into a raw image, it does not size the output file properly. When no offset is given, the file is sized correctly: $ mkimg -f raw -o temp.img -s mbr -p freebsd::512000 creates a file that is 1001 blocks long. Relative offsets work well: $ mkimg -f raw -o temp.img -s mbr -p freebsd::512000:+512 creates a file that is 1002 blocks long. But: $ mkimg -f raw -o temp.img -s mbr -p freebsd::512000:512 creates a file that is only 1 block long, instead of 1001. Looking at the code, in file mkimg.c the problem seems to be that the "bloc= k" variable is not updated with the partition size. But I could not understand= the code well enough to propose a patch, unfortunately. Additional info: $ uname -a FreeBSD myhost 11.4-STABLE FreeBSD 11.4-STABLE #1 r369279: Tue Feb 16 10:16= :53 CET 2021 root@myhost:/usr/obj/usr/src/sys/GENERIC amd64 $ svn info /usr/src/usr.bin/mkimg | grep Revision Revision: 369279 --=20 You are receiving this mail because: You are the assignee for the bug.=