Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Jun 2010 12:27:09 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Alexander Motin <mav@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r208988 - in head/sys: kern sys
Message-ID:  <20100611092709.GG2401@deviant.kiev.zoral.com.ua>
In-Reply-To: <4C11FD57.2000400@FreeBSD.org>
References:  <201006101614.o5AGE5Zh099383@svn.freebsd.org> <20100611083137.GA2401@deviant.kiev.zoral.com.ua> <4C11FD57.2000400@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--L1c6L/cjZjI9d0Eq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 11, 2010 at 12:09:43PM +0300, Alexander Motin wrote:
> Kostik Belousov wrote:
> > On Thu, Jun 10, 2010 at 04:14:05PM +0000, Alexander Motin wrote:
> >> Author: mav
> >> Date: Thu Jun 10 16:14:05 2010
> >> New Revision: 208988
> >> URL: http://svn.freebsd.org/changeset/base/208988
> >>
> >> Log:
> >>   Store interrupt trap frame into struct thread. It allows interrupt h=
andler
> >>   to obtain both trap frame and opaque argument submitted on registrct=
ion.
> >>   After kernel and all drivers get used to it, legacy hack can be remo=
ved.
> >>  =20
> >>   Reviewed by:	jhb@
> > Just curious, why td_frame is not enough for your usage ? I believe td_=
frame
> > is currently set only by traps and syscalls, and copied on forks.
Correction: and ast().
>=20
> I've seen that field, but I have no idea how it is used. I see a lot of
> usage places and not sure that none of them called inside interrupt
> filter. I didn't want to break something unexpected. If you sure - it is
> easy to change.
I believe it is safe to use it in a way that you intended to use
td_intr_frame. In the current code, interrupt handler cannot rely on
the content of td_frame, your save/restore brackets should do the right
thing.

--L1c6L/cjZjI9d0Eq
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)

iEYEARECAAYFAkwSAW0ACgkQC3+MBN1Mb4i6tQCfciXOdas8KQmC0W60lnF7GUNf
2A0An1bkq+dl2HBh5fGDiPlzDVnOstbZ
=5w3x
-----END PGP SIGNATURE-----

--L1c6L/cjZjI9d0Eq--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100611092709.GG2401>