From owner-freebsd-current@FreeBSD.ORG Fri Dec 30 20:20:40 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 890EB16A41F; Fri, 30 Dec 2005 20:20:40 +0000 (GMT) (envelope-from cracauer@schlepper.zs64.net) Received: from schlepper.zs64.net (schlepper.zs64.net [212.12.50.230]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0379C43D45; Fri, 30 Dec 2005 20:20:30 +0000 (GMT) (envelope-from cracauer@schlepper.zs64.net) Received: from schlepper.zs64.net (schlepper [212.12.50.230]) by schlepper.zs64.net (8.13.3/8.12.9) with ESMTP id jBUKKRgQ039365; Fri, 30 Dec 2005 21:20:27 +0100 (CET) (envelope-from cracauer@schlepper.zs64.net) Received: (from cracauer@localhost) by schlepper.zs64.net (8.13.3/8.12.9/Submit) id jBUKKRAu039364; Fri, 30 Dec 2005 15:20:27 -0500 (EST) (envelope-from cracauer) Date: Fri, 30 Dec 2005 15:20:27 -0500 From: Martin Cracauer To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= Message-ID: <20051230152027.A39043@cons.org> References: <20051229221459.A17102@cons.org> <030d01c60cf1$db80a290$1200a8c0@gsicomp.on.ca> <20051230035724.GA52167@nagual.pp.ru> <20051230125227.A33408@cons.org> <43B580D2.9070609@freebsd.org> <20051230142848.A36879@cons.org> <86psne2wd2.fsf@xps.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: <86psne2wd2.fsf@xps.des.no>; from des@des.no on Fri, Dec 30, 2005 at 08:55:21PM +0100 Cc: Martin Cracauer , freebsd-current@freebsd.org, Colin Percival Subject: Re: fetch extension - use local filename from content-dispositionheader (new diff) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2005 20:20:40 -0000 Dag-Erling Smørgrav wrote on Fri, Dec 30, 2005 at 08:55:21PM +0100: > Martin Cracauer writes: > > DES, can you be more specific in what way I break the API? > > You changed the size of struct url_stat. Not to argue but that is an ABI change, not an API one. I certainly don't see how this qualifies as "disgusting" as you put it. Ok, how about I change the inline struct to a constructor/pointer-passing mechanism (with changed names) and we bump the shared library version number? That way fields can be added in an ABI and API backwards-compatible manner in the future. The way it is organized right now libfetch effectivly shields the application from HTTP headers and the API chosen for header information transportation is locked against extensions. Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer http://www.cons.org/cracauer/ FreeBSD - where you want to go, today. http://www.freebsd.org/