From owner-dev-commits-src-all@freebsd.org Tue Aug 24 16:45:02 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4817965B3EC; Tue, 24 Aug 2021 16:45:02 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GvFMf109Cz4ZZ8; Tue, 24 Aug 2021 16:45:02 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-lf1-x12a.google.com with SMTP id o10so46829461lfr.11; Tue, 24 Aug 2021 09:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ja/3H8dl+/XQh34gBZZfcOranCJ+xED03YFPnFzo5Gs=; b=HMJgfJgAcx9GHRDXJPexI06ENHgHthalpvxuRkXcilg7Ca4PRfVXrr+dSlz54sTBYB DFT78nKLt47phYL2wn2wWvJYgCSO9ToGjfa+AcClwIYcYuyXVdPDyne2YGNe2iJS02Sa CIZHhbuAbE1B2w0GpVp0v0Mg9Bj4LaK6+qyMjSgE+s7N4kkQlNAY8hyhy5D3U0Zf4sjS 3s6+z/4siAYblE8rH4bxWX+R9HJgVhUsG+9Od/rDpW+jyoTNhYWAecEEq/YcGDwXOLjF GGw0IT+2esQc3SGiOd/RPKtYCzfOiQSkL2hoBiZ7MSYtfwYfwnPkqVFwY1BYEgaOiIqE eY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ja/3H8dl+/XQh34gBZZfcOranCJ+xED03YFPnFzo5Gs=; b=Szd0VeZ/d43otKzKfpdd1BYLgM7lwsHEco67rR7RNyTRWEJhcGmQGOcWG9mEUxSk72 djeaUDR2an9iVHEEqta7oz1tbuq6ZH+yAqXs/SNzWQJ70V1kHiyJKEW2yFToLUs7O2IS gFRg3L79WVydhVo+vVSfcJsb+BmF+tNUxemvONxOe2nMlUdtcglbjQ7BmeyPvl7op6Ur GBcIIf/sm6ypI/6IHLeSXN41eFIPlmD1UaLMmFFA7PtkogLAN7E78z/sa5/K9IDqnkFO h0/QR7EzPdtYcP5O773FO2pHzNV9MIwbMS8xa36MJVfvNWizkGhTkk3WKa/voGS3kG0j Jn9Q== X-Gm-Message-State: AOAM531Ti9YfEdA72ZGZ8lB4QDrK4w2ON4GETC5AS4KWcAM766OVJVLq xs7TdjtxiyDEXUSGa56gj0vsZkoeJ9GatxL17zTUQDHL X-Google-Smtp-Source: ABdhPJwqBfU6h0yyuEOneACd6D2NJ88RASFxKan/hefsKImgUSvTtGemrznqitY0UqWSNjdZAA4mQZ8nZn4STXcjG4I= X-Received: by 2002:a05:6512:541:: with SMTP id h1mr28854325lfl.118.1629823494757; Tue, 24 Aug 2021 09:44:54 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:6f04:0:0:0:0:0 with HTTP; Tue, 24 Aug 2021 09:44:54 -0700 (PDT) In-Reply-To: <202108241637.17OGbGVi074299@gitrepo.freebsd.org> References: <202108241637.17OGbGVi074299@gitrepo.freebsd.org> From: Mateusz Guzik Date: Tue, 24 Aug 2021 18:44:54 +0200 Message-ID: Subject: Re: git: a48416f844e3 - main - tmpfs: Fix error being cleared after commit c12118f6cec0 To: Ka Ho Ng Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4GvFMf109Cz4ZZ8 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 16:45:02 -0000 On 8/24/21, Ka Ho Ng wrote: > The branch main has been updated by khng: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=a48416f844e3007b4e9f6df125e25cf3a1daad62 > > commit a48416f844e3007b4e9f6df125e25cf3a1daad62 > Author: Ka Ho Ng > AuthorDate: 2021-08-24 16:35:29 +0000 > Commit: Ka Ho Ng > CommitDate: 2021-08-24 16:35:29 +0000 > > tmpfs: Fix error being cleared after commit c12118f6cec0 > > In tmpfs_link() error was erroneously cleared in commit c12118f6cec0. > > Sponsored by: The FreeBSD Foundation > MFC after: 3 days > MFC with: c12118f6cec0 > --- > sys/fs/tmpfs/tmpfs_vnops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/fs/tmpfs/tmpfs_vnops.c b/sys/fs/tmpfs/tmpfs_vnops.c > index 325b8d2789bb..326a5132990d 100644 > --- a/sys/fs/tmpfs/tmpfs_vnops.c > +++ b/sys/fs/tmpfs/tmpfs_vnops.c > @@ -808,7 +808,7 @@ tmpfs_link(struct vop_link_args *v) > error = 0; > > out: > - return (0); > + return (error); > } > You should use coccinelle for changs like this. > /* > -- Mateusz Guzik