From owner-p4-projects@FreeBSD.ORG  Sat Jan  7 20:08:41 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5001E16A427; Sat,  7 Jan 2006 20:08:40 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0CFD016A423
	for <perforce@freebsd.org>; Sat,  7 Jan 2006 20:08:40 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B1DBD43D45
	for <perforce@freebsd.org>; Sat,  7 Jan 2006 20:08:39 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k07K8dYB045724
	for <perforce@freebsd.org>; Sat, 7 Jan 2006 20:08:39 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k07K8dK2045721
	for perforce@freebsd.org; Sat, 7 Jan 2006 20:08:39 GMT
	(envelope-from imp@freebsd.org)
Date: Sat, 7 Jan 2006 20:08:39 GMT
Message-Id: <200601072008.k07K8dK2045721@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 89345 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jan 2006 20:08:41 -0000

http://perforce.freebsd.org/chv.cgi?CH=89345

Change 89345 by imp@imp_plunger on 2006/01/07 20:07:47

	Just realized that this isn't quite right, add a comment to
	that effect so I don't forget.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#17 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#17 (text+ko) ====

@@ -523,6 +523,10 @@
 	WR4(sc, ETH_TAR, segs[0].ds_addr);
 	WR4(sc, ETH_TCR, segs[0].ds_len);
 	
+	/* XXX the following is wrong, we need to keep track of the mbuf and
+	 * only free it when the ISR fires indicating xmit complete.
+	 */
+
 	/*
 	 * Tap off here if there is a bpf listener.
 	 */