From nobody Tue Nov 25 22:58:59 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dGJ684tMHz6Hx4s for ; Tue, 25 Nov 2025 22:59:12 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dGJ675RsHz3fvw for ; Tue, 25 Nov 2025 22:59:11 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-948da744f87so224647239f.1 for ; Tue, 25 Nov 2025 14:59:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764111550; x=1764716350; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qSrjv4ybd3Awl51dsBD1/L/wsCJHcaZOPoi/EFDv3J4=; b=Osdj0Dq1PwHSkR3GCZiZQZYwLGppW0jl2rdvexR80SIGFGucCQsfECENPiCCbvOjP3 zDCQsGbqKALIL3dGApAQucZwduNvT2eKttwPrU7CoR7b1y2mZsFS2a71Xf+HAunP9mHp 0LPDJx17F2S0IzMeRypTNYEmX0fC3WpyQEljRZ2/PFeglMbM3vj+tYfZbrhJ4qZ0A05S TUx6gDGQkOCOxFaX1nFE6v54ocO8NMOBq0XfvcksQ6uKMbpRBV17ZIJb4Oc1dh4ieLWN 2I9mDDxlK6jzIap70CoE6qmstk34yqa+5wSs3jOAXk5JjnTivpaQu0OXWXlkKL281/AQ 6gMQ== X-Gm-Message-State: AOJu0YyNbYONdGxL0EHbSAM81Fo/U2kwCmHPvdnXnkWxgDo37QYP2Vk+ MTTuKtZ3E+VfjSzkXfeUqEPbVPrhn/azAi9V/msubC9zEjTjQl8uqNKJnD8WJuYIUG1cDSQURkJ bJ0P5Cv5bmWAdGBbejEyNgcTwY1ATbha+RRJe X-Gm-Gg: ASbGncvcxLRTgdnh1Ki9qJ+eEFYRiQZTz6Dwv+q3uNIwXoZgcdCaxyM57ZhCg82Yvqi /yreDeBeHIgJqD8pn+N7KuSeAExIuAnidGfCi3dfOkioyQo9bGyczxgN329BWG77n9/IWxPjNpG EhTCh8dB7eAWMuQHipxhji33h3U05qQv++Ma4HFR/VcdsThoh2cRkl1xElmT5c0N1knIbCez/li +YWSWgOESsjiLdvwpnG48KnpRBRVAy3WJnzuxrAvctDhalPcE8DZjaHhwcCBW/05A4GfaygUt+/ 2vf2acuv6CYP4w5y+JZltDYzg44= X-Google-Smtp-Source: AGHT+IH3gVfypPUrSnlWBUyCZs16soFvVbvX76olS0giFrFj5nskWR1BfzPa6rWvlUQ2P4/siCsc+ksPFzgmHLru6i8= X-Received: by 2002:a05:6638:ad56:b0:5b7:c4b0:a183 with SMTP id 8926c6da1cb9f-5b9993ec8a4mr2863572173.0.1764111550273; Tue, 25 Nov 2025 14:59:10 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 From: Ed Maste Date: Tue, 25 Nov 2025 17:58:59 -0500 X-Gm-Features: AWmQ_blNgb5C9LaZXFbvHVTusgVlgVSGh8C1j2US16bno4xz-LicmTHqCVF3bUc Message-ID: Subject: Request for testing [was: Heads-up: Kernel module symbol resolution changing] To: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: - X-Spamd-Result: default: False [-1.32 / 15.00]; NEURAL_HAM_MEDIUM(-0.86)[-0.863]; NEURAL_HAM_LONG(-0.33)[-0.330]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; NEURAL_HAM_SHORT(-0.22)[-0.224]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; MISSING_XM_UA(0.00)[]; FREEFALL_USER(0.00)[carpeddiem]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; RCVD_COUNT_ONE(0.00)[1]; R_DKIM_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.46:from]; TO_DOM_EQ_FROM_DOM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.46:from] X-Rspamd-Queue-Id: 4dGJ675RsHz3fvw On Wed, 12 Mar 2025 at 13:07, Ed Maste wrote: > > Our in-kernel module linker currently performs symbol resolution > against local symbols from other modules, which is a bug. > > In commits 95c20faf11a1 and ecd8245e0d77 kib introduced support to > have the kernel linker stop resolving local symbols from other files, > but did not change it by default to avoid surprises. The > debug.link_elf_leak_locals sysctl controls this behaviour, currently > defaulting to resolving against local symbols (1). Setting it to 0 > turns this off. > > I plan to flip the default soon, in advance of FreeBSD 15.0. See > PR207898 and https://reviews.freebsd.org/D47742 for more information. This did not happen for 15.0, but should for 16.0. I flipped the default earlier today but reverted again after reports of module load failures and because it's currently stabweek. I hope to commit it again next week, and need some help identifying and resolving potential issues before doing so. A failure will show up on the system console (and in dmesg, /var/log/messages) as something like: link_elf_obj: symbol kern_kmq_open undefined linker_load_file: /boot/kernel/linux.ko - unsupported file type I'm aware of two failures so far: 1. i915kms.ko, on a system with agp built as a module PR291214, fixed by a87c1e2dd8fc 2. linux.ko (presumably) due to kern_kmq_* symbols Fix in review: https://reviews.freebsd.org/D53907 There is also a possible issue with x11/nvidia-driver, but it may not be related. Investigation is ongoing in PR291212. I would appreciate it if folks can test other modules. To do so, add the following lines to /boot/loader.conf and reboot: debug.link_elf_leak_locals=0 debug.link_elf_obj_leak_locals=0 If any module starts failing to load (with "symbol ____ undefined" console messages) please open a PR with the details. Then remove the loader.conf lines and carry on as before.