From owner-cvs-src@FreeBSD.ORG Fri Oct 26 18:21:37 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D828E16A469; Fri, 26 Oct 2007 18:21:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 3F2D213C4AC; Fri, 26 Oct 2007 18:21:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 216251103-1834499 for multiple; Fri, 26 Oct 2007 14:23:42 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9QIKdC4037881; Fri, 26 Oct 2007 14:20:57 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Fri, 26 Oct 2007 14:04:54 -0400 User-Agent: KMail/1.9.6 References: <200710261500.l9QF0ZJ0036161@repoman.freebsd.org> <200710261136.54938.jhb@freebsd.org> <20071026.095939.-432837659.imp@bsdimp.com> In-Reply-To: <20071026.095939.-432837659.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710261404.55441.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 26 Oct 2007 14:20:58 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/4600/Fri Oct 26 10:02:30 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/boot/common ufsread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2007 18:21:38 -0000 On Friday 26 October 2007 11:59:39 am M. Warner Losh wrote: > In message: <200710261136.54938.jhb@freebsd.org> > John Baldwin writes: > : On Friday 26 October 2007 11:00:34 am Warner Losh wrote: > : > imp 2007-10-26 15:00:34 UTC > : > > : > FreeBSD src repository > : > > : > Modified files: > : > sys/boot/common ufsread.c > : > Log: > : > The arm boot code uses this function as well. Redefining cgbase() > : > saves about 500 bytes in the boot code. While the AT91RM9200 has 12k > : > of space for the boot loader, which is more than i386's 8k, the code > : > generated by gcc is a bit bigger. > : > > : > I've had this in p4 for about two years now. > : > > : > Revision Changes Path > : > 1.16 +1 -1 src/sys/boot/common/ufsread.c > : > > : > : We should probably change this to be #ifdef SMALL_CGBASE or some such then and > : just define it before ufsread.c in boot2.c and other files that include it. > : Does that sound ok to you (or do you have a better name?) UFS_SMALL_CGBASE > : maybe? > > I can't think of a better name, but that does sound good to me. It > would also allow finer granularity of control for these things. Ok. > One thing I'm unsure about is the amd64 boot blocks. Do those get > build -D__i386__? Are they just the i386 boot blocks because amd64 > boxes boot in the same old mode than 32-bit x86 boxes boot? Yes and yes. -- John Baldwin