From owner-cvs-all@FreeBSD.ORG Wed Aug 29 15:36:32 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 839AE16A417; Wed, 29 Aug 2007 15:36:32 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 9478A13C459; Wed, 29 Aug 2007 15:36:31 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7TFaSwR035212; Wed, 29 Aug 2007 19:36:29 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7TFaSbB035211; Wed, 29 Aug 2007 19:36:28 +0400 (MSD) (envelope-from yar) Date: Wed, 29 Aug 2007 19:36:28 +0400 From: Yar Tikhiy To: Alexander Leidinger Message-ID: <20070829153628.GC31948@comp.chem.msu.su> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> <20070827151033.GM21352@comp.chem.msu.su> <20070829152957.01a71f01@deskjail> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070829152957.01a71f01@deskjail> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 15:36:32 -0000 [Cc: list trimmed] On Wed, Aug 29, 2007 at 03:29:57PM +0200, Alexander Leidinger wrote: > Quoting Yar Tikhiy (Mon, 27 Aug 2007 19:10:34 +0400): > > > On Mon, Aug 27, 2007 at 04:26:55PM +0200, Alexander Leidinger wrote: > > > > > > So the really important thing for you is: How many ports are affected > > > by this change? > > > > > > Does anyone have an estimate for this? > > > > > > If not, does someone has an exhaustive list of affected symbols? I can > > > write a short script which has a look into each installed port to > > > determine if it is affected or not (based upon the assumption that you > > > don't mind if we overlook a few things... I'm not sure if statically > > > linked binaries contain enough information). > > > > With the resolution approaching to avoid compatibility in fts(3) > > now and my experiment on improving src/Makefile.inc1 going on really > > well, I think I should estimate which ports are going to be affected. > > I'll do so by searching binary packages for CURRENT, so some ports > > can slip through my sieve. The symbols to look for match the simple > > pattern: fts_* (or regexp: ^fts_.*). I don't think there are a lot > > of ports using those functions. > > > > Here's the exact list of symbols to be affected: > > > > fts_open > > fts_close > > fts_read > > fts_set > > fts_children > > fts_get_clientptr > > fts_get_stream > > fts_set_clientptr > > > > Attached are two scripts. find_fts.sh has to be in the PATH. It returns > the files specified at the command line, which contain unresolved > references to fts_* (e.g. "find_fts.sh /bin/*"). The other script > parses a +CONTENTS file of an installed port and hands over the > executables and libraries to find_fts.sh. If it finds a match, it > prints the port origin. > > I let it run on my >800 installed ports via > for i in /var/db/pkg/*;do; ./analyse_ports_for_fts_abi_change.sh $i;done > > It didn't find a match. I hope this is not because of a bug in my > script... Here's the list of ports that are likely to use fts(3) because binaries in their CURRENT packages reference fts_ symbols. Note, however, that it isn't 100% certain yet whether the ABI should be broken, so it may be a bit too early to worry about them. :-) archivers/xar audio/ifp-line cad/brlcad chinese/xmms deskutils/fusenshi ftp/ftpd-tls ftp/tnftpd japanese/jls mail/mboxgrep mail/qmail-remove multimedia/audacious multimedia/beep-media-player multimedia/xmms net-mgmt/nfdump-devel net/coda6_client net/coda6_server net/kissd news/husky-fidoconf news/husky-fidoconf-devel news/husky-hpt news/husky-hpt-devel news/husky-hptkill ports-mgmt/pkg_install ports-mgmt/pkg_install-devel russian/xmms security/amavisd-milter security/destroy security/rdigest security/srm sysutils/vcp textproc/bsdgrep textproc/freegrep www/polipo -- Yar