Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 01 Apr 2018 13:35:45 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Jeff Roberson <jeff@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r327954 - in head/sys: amd64/conf conf dev/acpica vm x86/acpica
Message-ID:  <1522611345.49673.175.camel@freebsd.org>
In-Reply-To: <201801140336.w0E3a3xv010728@repo.freebsd.org>
References:  <201801140336.w0E3a3xv010728@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2018-01-14 at 03:36 +0000, Jeff Roberson wrote:
> Author: jeff
> Date: Sun Jan 14 03:36:03 2018
> New Revision: 327954
> URL: https://svnweb.freebsd.org/changeset/base/327954
> 
> Log:
>   Move VM_NUMA_ALLOC and DEVICE_NUMA under the single global config
> option NUMA.
>   
>   Sponsored by:	Netflix, Dell/EMC Isilon
>   Discussed with:	jhb

It turns out this breaks building powerpc lint kernels. It shakes out
like this... makeLINT.mk copies sys/conf/NOTES into the generated LINT
config (I guess on the theory that things documented in NOTES are
supported by all arches). So option NUMA is present on powerpc, but the
powerpc vmparam.h doesn't define VM_LEVEL_0_ORDER so the build fails.
(Mips also doesn't define that, but it has no lint kernel build at all
right now.)

It could be fixed in vm_domainset.c with:

-#ifdef NUMA
+#if defined(NUMA) && defined(VM_LEVEL_0_ORDER)

but there may be some better way to fix it, I don't know that much
about this stuff.

-- Ian



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1522611345.49673.175.camel>