From owner-svn-src-head@freebsd.org Wed Dec 9 17:01:38 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 452A09D618C; Wed, 9 Dec 2015 17:01:38 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id 2EBC917B7; Wed, 9 Dec 2015 17:01:38 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from sweettea.beer.town (unknown [76.164.8.130]) by smtp.vangyzen.net (Postfix) with ESMTPSA id 53E1956489; Wed, 9 Dec 2015 11:01:37 -0600 (CST) Subject: Re: svn commit: r291994 - head/include To: Hajimu UMEMOTO , Bruce Evans References: <201512081609.tB8G9mfd053070@repo.freebsd.org> <20151209173008.A828@besplex.bde.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Eric van Gyzen Message-ID: <56685E6D.5020403@FreeBSD.org> Date: Wed, 9 Dec 2015 11:01:33 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 17:01:38 -0000 On 12/09/2015 10:43, Hajimu UMEMOTO wrote: > Hi, > >>>>>> On Wed, 9 Dec 2015 18:19:16 +1100 (EST) >>>>>> Bruce Evans said: > > brde> resolv.h already had massinve namespace pollution and style bugs in > brde> its includes. One more include of a header that is relatively clean > brde> since it is tiny and was designed for minimising namespace pollution > brde> makes little difference. > > I understood. Thank you for your detailed explanation. > However, I realized that r289315 changed the size of struct > __res_state. It broke binary backward compatibility. I think we > still need to revert its change in struct __res_state and move them > into struct __res_state_ext. Thank you both for your input. I agree with moving the fields. https://reviews.freebsd.org/D4472 Eric