From owner-freebsd-wireless@FreeBSD.ORG Mon Mar 5 19:19:37 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A9BCD106564A; Mon, 5 Mar 2012 19:19:37 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id 0F4318FC0C; Mon, 5 Mar 2012 19:19:36 +0000 (UTC) Received: by wgbds11 with SMTP id ds11so1572349wgb.1 for ; Mon, 05 Mar 2012 11:19:36 -0800 (PST) Received-SPF: pass (google.com: domain of adrian.chadd@gmail.com designates 10.216.131.2 as permitted sender) client-ip=10.216.131.2; Authentication-Results: mr.google.com; spf=pass (google.com: domain of adrian.chadd@gmail.com designates 10.216.131.2 as permitted sender) smtp.mail=adrian.chadd@gmail.com; dkim=pass header.i=adrian.chadd@gmail.com Received: from mr.google.com ([10.216.131.2]) by 10.216.131.2 with SMTP id l2mr4742129wei.3.1330975176070 (num_hops = 1); Mon, 05 Mar 2012 11:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=I5FCyQFOIlLAti9VNpacw9jFBH9d5Fdga9RewEnCMPo=; b=St86WwEb8kINnXYtX95QX1OSrijmpNIFdEK9ZWUabUC1P4pt2gmaf8BPnzDxN0xExJ BDm01iV0fZ2EW77T0ckyVTscyDpXGwErOrJOoSqjT7Edk/LE7GfXjTN9YxTuiFn4b7cg RR0JIHJsNT0IooogRl441/7IJuaMvcLvehDdLhftHO4t9dCe88C34uXY8fpyRXkMZrby ZjUQJRVFzIuTVCYmgsTm/Qxbws1bhOzYBjZfsU9rFOYE7NwCAd4EARKbjZkLbpyJ018f FvhQk5XymHbF0lWVfzofpqouYaXN3dq9SYfCxiT31+LaRhQzy0iO9RMlBQjop1dBdBDg ku7g== MIME-Version: 1.0 Received: by 10.216.131.2 with SMTP id l2mr3793808wei.3.1330975175962; Mon, 05 Mar 2012 11:19:35 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.198.81 with HTTP; Mon, 5 Mar 2012 11:19:35 -0800 (PST) In-Reply-To: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> Date: Mon, 5 Mar 2012 11:19:35 -0800 X-Google-Sender-Auth: rq7qe7XVu2mkQlmciWxbFbZo_ts Message-ID: From: Adrian Chadd To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 19:19:37 -0000 Hi! (cc'ing freebsd-wireless, where we try to talk about this kind of stuff...) On 5 March 2012 09:42, Mitsuru IWASAKI wrote: > Hi, > > I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work > in WEP mode, which seems to be broken since 8.0-RELEASE. Thanks for looking into this! I've not looked into ath(4) and WEP (ever, to be honest) - I really should. I wonder if it's similarly broken. But if it isn't, ath(4) doesn't yet use if_transmit/if_flush. That's on my TODO list (in order to fix fragment handling, rather than WEP.) Would you please open a PR with this particular issue and then attach the patch to it? I'd rather you not commit the net80211 change until I've verified that WEP works or doesn't work with ath(4). Thanks! Adrian > > The patches against HEAD at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff > > I'm not sure that changes on ieee80211 layer are right fixes, > but all of mbufs were discarded in ieee80211_start() in WEP mode. > > ---- > void > ieee80211_start(struct ifnet *ifp) > { > [snip] > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (ni->ni_associd =3D=3D = 0 && > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(ni->ni_flags & IE= EE80211_NODE_ASSOCID)) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0IEEE80211_= DISCARD_MAC(vap, IEEE80211_MSG_OUTPUT, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0eh= ->ether_dhost, NULL, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"s= ta not associated (type 0x%04x)", > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ht= ons(eh->ether_type)); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0vap->iv_st= ats.is_tx_notassoc++; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ifp->if_oe= rrors++; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0m_freem(m)= ; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ieee80211_= free_node(ni); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0continue; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > ---- > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > is set. =A0Any suggestions on this part are welcome. > > I'm going to commit the changes coming weekend. > > Thanks! > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= "