From owner-cvs-all Sun Oct 7 12:37:18 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 58EF537B405; Sun, 7 Oct 2001 12:37:14 -0700 (PDT) Received: (from des@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f97JbE014482; Sun, 7 Oct 2001 12:37:14 -0700 (PDT) (envelope-from des) Message-Id: <200110071937.f97JbE014482@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: Sun, 7 Oct 2001 12:37:14 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/fs/procfs procfs_vnops.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG des 2001/10/07 12:37:14 PDT Modified files: sys/fs/procfs procfs_vnops.c Log: In procfs_readdir(), when the directory being read was a process directory, the target process was being held locked during the uiomove() call. If the process calling readdir() was the same as the target process (for instance 'ls /proc/curproc/'), and uiomove() caused a page fault, the result would be a proc lock recursion. I have no idea how long this has been broken - possibly ever since pfind() was changed to lock the process it returns. Also replace the one and only call to procfs_findtextvp() with a direct test of td->td_proc->p_textvp. Revision Changes Path 1.103 +4 -2 src/sys/fs/procfs/procfs_vnops.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message