From owner-freebsd-testing@FreeBSD.ORG Tue Apr 22 00:21:23 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 630FF733; Tue, 22 Apr 2014 00:21:23 +0000 (UTC) Received: from mail-vc0-x232.google.com (mail-vc0-x232.google.com [IPv6:2607:f8b0:400c:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0BEE119AD; Tue, 22 Apr 2014 00:21:22 +0000 (UTC) Received: by mail-vc0-f178.google.com with SMTP id im17so1810045vcb.9 for ; Mon, 21 Apr 2014 17:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=aAI5U+SG+71aSMvX7lukHVqJ9Y4pq20ks3Xn+zJ5NRY=; b=fjn+EuqtZelYvBsReqH/mS6Bhh09NrnU86PBgjAN9pmvOM4xhLFkkQ5Cy5tZLGmVWL VguSCYJIJc4+f15KbXkz8buKBU09WluumEKT7/x9qc8JBUb7+TB4skNiij9NoERnc/26 AKUh2kpfrT+I1n9fZS4iwZ4sz0Ef0j78yi/5hi/riMaAEN/fmt/IFRXPCtfaPK1OLMDN UuZthLMCzQ0GrnKG9ly5ctU472OSQpFQ+cVYoBcdafyLFT47S1ImPQvEsdbFkIgRjZqA Q4ojXQrvka4yNqnchRRUbGSbGyuPZDnvluhN3AYcXVkxDpKyyhhiBoSDy5MMYu6Ld2dU SFXw== MIME-Version: 1.0 X-Received: by 10.52.37.196 with SMTP id a4mr2723232vdk.33.1398126082167; Mon, 21 Apr 2014 17:21:22 -0700 (PDT) Received: by 10.221.67.136 with HTTP; Mon, 21 Apr 2014 17:21:22 -0700 (PDT) In-Reply-To: References: <20140124162759.GB90996@stack.nl> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> Date: Mon, 21 Apr 2014 17:21:22 -0700 Message-ID: Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF From: Garrett Cooper To: Julio Merino Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-testing@freebsd.org" , Jilles Tjoelker X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Apr 2014 00:21:23 -0000 On Sun, Mar 9, 2014 at 1:42 PM, Julio Merino wrote: ... > The tests need to populate /usr/tests/bin/sh/ with the > functional_test.sh driver and all its supporting data files. As I > understand it, your driver code assumes that the data files are > external (i.e. not bundled into the script itself), so those files > must be available from the same location as where the driver lives. > Hence you still need to use FILES to ensure the data files get > installed into /usr/tests/. > > ... but maybe I'm missing something from your patch; haven't reviewed > it again to double-check this. I've reduced the diff quite a bit. The end result of it can be found here: https://github.com/yaneurabeya/freebsd/pull/2 (and it will evolve over time if needed because github is additive in pull request reviews). FWIW, it might be better to actually review it on github instead of using this list as patches attached to any mailing list can become stale over time. You can get the diff like so: https://github.com/yaneurabeya/freebsd/pull/2.patch Thanks! -Garrett