Date: Mon, 21 Apr 2014 17:21:22 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <jmmv@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Jilles Tjoelker <jilles@stack.nl> Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF Message-ID: <CAGHfRMApcpwKDnE0DQem_LbfwfhJ%2BZemg38gObAUc=bd3Xup1A@mail.gmail.com> In-Reply-To: <CAFY7cWCQKVuvSTNN7issLCHXWcuNPsysk38yLDzcMpkKy5EJ_w@mail.gmail.com> References: <B5290C1B-F262-479C-8D4F-A5D8B3CE5A52@gmail.com> <20140124162759.GB90996@stack.nl> <CADyfeQUfxi43A4aXg%2Bdu1oGkQAjJFYH1CCXSSoaLKz8nX2hapw@mail.gmail.com> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> <CAFY7cWCBGmZA1GdSNwNPcSeu_vLTHkSs0aMk3sb6sMs2H-Gn8Q@mail.gmail.com> <CAGHfRMBvawY9_%2BYDAeMhVYftW0gNG6ZKZ2i1dL0a0xb-6hMocg@mail.gmail.com> <CAFY7cWCQKVuvSTNN7issLCHXWcuNPsysk38yLDzcMpkKy5EJ_w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 9, 2014 at 1:42 PM, Julio Merino <jmmv@freebsd.org> wrote:
...
> The tests need to populate /usr/tests/bin/sh/ with the
> functional_test.sh driver and all its supporting data files. As I
> understand it, your driver code assumes that the data files are
> external (i.e. not bundled into the script itself), so those files
> must be available from the same location as where the driver lives.
> Hence you still need to use FILES to ensure the data files get
> installed into /usr/tests/.
>
> ... but maybe I'm missing something from your patch; haven't reviewed
> it again to double-check this.
I've reduced the diff quite a bit. The end result of it can be
found here: https://github.com/yaneurabeya/freebsd/pull/2 (and it will
evolve over time if needed because github is additive in pull request
reviews). FWIW, it might be better to actually review it on github
instead of using this list as patches attached to any mailing list can
become stale over time.
You can get the diff like so:
https://github.com/yaneurabeya/freebsd/pull/2.patch
Thanks!
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMApcpwKDnE0DQem_LbfwfhJ%2BZemg38gObAUc=bd3Xup1A>