Date: Fri, 05 Dec 1997 19:21:22 -0800 From: Studded <Studded@dal.net> To: "Jordan K. Hubbard" <jkh@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c machdep.c trap.c Message-ID: <3488C4B2.6A201B07@dal.net> References: <199712041436.GAA13167@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------139C65B7C7E45330CCDDFFC4 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Jordan K. Hubbard wrote: > > jkh 1997/12/04 06:36:58 PST > > Modified files: (Branch: RELENG_2_2) > sys/i386/i386 identcpu.c machdep.c trap.c > Log: > MFC: F00F cleanup. > > Revision Changes Path > 1.7.2.12 +3 -3 src/sys/i386/i386/identcpu.c > 1.209.2.16 +4 -4 src/sys/i386/i386/machdep.c > 1.83.2.4 +5 -5 src/sys/i386/i386/trap.c I'm still getting the errors in the first attachment when compiling the kernel with -Wall on 2.2.5-Stable. Even if it's not compiled with -Wall, it's still giving errors, which people on -questions have asked about already. Given that this is supposed to be a "bug fix" I think it behooves us to make at least machdep.c compile clean. I realize that these errors probably are not significant, and if I could fix them I would. If y'all would prefer that I quit bugging you about this, just say the word, but from the PR standpoint at least, it would be nice if these warnings would go away. :) Doug --------------139C65B7C7E45330CCDDFFC4 Content-Type: text/plain; charset=us-ascii; name="f00f" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="f00f" cc -c -O -Wall -pipe -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -nostdinc -I- -I. -I../.. -I../../../include -DCOMPAT_43 -DMSDOSFS -DFFS -DINET -DKERNEL ../../i386/i38 6/machdep.c ../../i386/i386/machdep.c: In function `cpu_startup': ../../i386/i386/machdep.c:231: warning: long unsigned int format, unsigned int arg (arg 2) ../../i386/i386/machdep.c:231: warning: long unsigned int format, unsigned int arg (arg 3) ../../i386/i386/machdep.c: In function `init386': ../../i386/i386/machdep.c:1085: warning: int format, long int arg (arg 2) ../../i386/i386/machdep.c: At top level: ../../i386/i386/machdep.c:1372: warning: initialization from incompatible pointer type ../../i386/i386/machdep.c: In function `f00f_hack': ../../i386/i386/machdep.c:1386: warning: assignment makes pointer from integer without a cast ../../i386/i386/machdep.c:1397: warning: passing arg 2 of `vm_map_protect' makes integer from pointer without a cast ../../i386/i386/machdep.c:1397: warning: passing arg 3 of `vm_map_protect' makes integer from pointer without a cast --------------139C65B7C7E45330CCDDFFC4 Content-Type: text/plain; charset=us-ascii; name="identcpu" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="identcpu" cc -c -O -Wall -pipe -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -nostdinc -I- -I. -I../.. -I../../../include -DCOMPAT_43 -DMSDOSFS -DFFS -DINET -DKERNEL ../../i386/i386/identcpu.c ../../i386/i386/identcpu.c: In function `printcpuinfo': ../../i386/i386/identcpu.c:395: warning: suggest parentheses around comparison in operand of & ../../i386/i386/identcpu.c:424: warning: unknown conversion type character `b' in format ../../i386/i386/identcpu.c:424: warning: too many arguments for format --------------139C65B7C7E45330CCDDFFC4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3488C4B2.6A201B07>