From owner-svn-src-head@FreeBSD.ORG Fri Nov 30 00:07:11 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CE552F03; Fri, 30 Nov 2012 00:07:11 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id AC10A8FC0C; Fri, 30 Nov 2012 00:07:10 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqAEAMf3t1CDaFvO/2dsb2JhbABEFoYWuXBzgh4BAQQBI1YFFg4GBAICDRkCWQaIEQMJBgysLYkFDYlUgSKLHoMugRMDiF6NI4EcjyiDEIID X-IronPort-AV: E=Sophos;i="4.84,188,1355115600"; d="scan'208";a="2656235" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu.net.uoguelph.ca with ESMTP; 29 Nov 2012 19:07:02 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id B5138B4060; Thu, 29 Nov 2012 19:07:02 -0500 (EST) Date: Thu, 29 Nov 2012 19:07:02 -0500 (EST) From: Rick Macklem To: Mateusz Guzik Message-ID: <1665336113.1002130.1354234022710.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <20121129003853.GB22327@dft-labs.eu> Subject: Re: svn commit: r243645 - head/usr.sbin/nfsd MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - FF3.0 (Win)/6.0.10_GA_2692) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Alfred Perlstein X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2012 00:07:12 -0000 Mateusz Guzik wrote: > On Wed, Nov 28, 2012 at 07:14:23PM -0500, Rick Macklem wrote: > > Mateusz Guzik wrote: > > > On Wed, Nov 28, 2012 at 02:47:32AM +0000, Alfred Perlstein wrote: > > > > Author: alfred > > > > Date: Wed Nov 28 02:47:31 2012 > > > > New Revision: 243645 > > > > URL: http://svnweb.freebsd.org/changeset/base/243645 > > > > > > > > Log: > > > > Don't allow minthreads > maxthreads. > > > > > > > Should not this be also checked in the kernel? Looks like > > > nfssvc_nfsd > > > is > > > trustful: > > > > > Well, since only root can do this and I can't think of why a > > sysadmin > > would use anything other than nfsd, I'm not sure it matters much? > > (But I don't see a problem with adding a sanity check in the kernel > > code.) > > > > It's nothing serious and I'm not going to insist, especially since > this > is your code. It's not my code, it's the collective's code. (For want of a better term for the FreeBSD project.;-) Also, I wasn't the author of the krpc related stuff (which these thread limits are a part of). I just cloned it from the old NFS server for the new one. > I just prefer the kernel to be resistant if it does not > cost much. > > I had something like this in mind (untested): > http://people.freebsd.org/~mjg/patches/nfs-threads-check.diff > Since it was alfred@'s patch, I'll let him decide. As I said before, I have no problem with adding the check to the kernel. Have fun with it, rick > -- > Mateusz Guzik