From nobody Fri May 17 06:48:16 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vgcww6X69z5KZr9; Fri, 17 May 2024 06:48:16 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vgcww5lkRz4mpM; Fri, 17 May 2024 06:48:16 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715928496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4fXkCrD5jlEOkRUrZ2/P67RwJiwfJhMUv9a5HGNYrvE=; b=tFN1dpPXvK1ALNffG3TZB69Ug3mRKxEHiO8hZhdRfStxLBI2IlF5MlIF2VUpIBCRrAeRfk p40mlXRFtYbeJzzpGsVUbY0k1Lpbigim/NPYfNorF+cRk7tgyZ2DGAXszNSNMhalxKvJnN qz4yExJl41Il3JvBwolR0LLI08Cf8Q4FXGVwWgTUMqfgQ0dm389r8N8DBDcBxhhAy2H5Tu 5pSZoXVDVZuLma/61B9s8PKjHScb8UecNyZX9gnOHHX4U4kOFHxqiQ88zCZqpjeSGTjzmE 0MsCJGR1W3EH8J7Oohvx16DsnLuIZZtcElG7Gkhz0/AHqTwrN1ye1GpevagncA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715928496; a=rsa-sha256; cv=none; b=pAwVqBsvaBmjCvowyz1h2uZ1H5fGkn0MkIGzQsZXdaLfWXHpbGMH0KK4q5isAQY4fLeoil MeKsx9wBeY3gf8upBVAIimL1gUO8Gl/a+6hgdGX9lmSjrJTy/vjAyAqL+D+LrtJNPwVwp6 rkKe6Y07n4CUcnp87cc03zfB6cqy6Kw+NmJkAPUzxNcb8z3Awcm2cE1DCYbBYuf7MdjqMy GxdkituPuu2yQGljSw7BbMaHUrx/E3+7O8HFW8S3ADPHw6sJTocX73xVhSTXk7GoMLCQq/ ljTezfCfwLiZQZ63dxFbZ1bKdQR8tb9hqt3piDCF0jbpONHX8WBCJ7ZmEhCiYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715928496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4fXkCrD5jlEOkRUrZ2/P67RwJiwfJhMUv9a5HGNYrvE=; b=QzoQjQ5GjlSLRJgv0awXhBRO2HQHJgqtYqUM4RrmjOf8F29uAzCqXFiXCqXEYG2Gc/56kV ZST8ScAmNTkXeDkcNEghu8R9n1wxU3iG+8eP8i+bo/1SmhQMQnE1BONT5rWPSUeXsv7tco 6x7l9cXnyYlFdMSSVkvxeMMr7REFGRzXU6K2Wvu3VdsKK0vIQz9m55mAviSqXRxRplzh9o cSX05IqqIoPTacAXUbrsQUCKv6FWoQY51rpiZqQHHVDvCCsowetk8R7UZMY4R0/IvJaL+k 6zJLztENgwh/QbnkfmJvVrVBxGU5aEd0p+tohA4KUgUtQfBXdv6LKMjor93Srw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 94E1211017; Fri, 17 May 2024 06:48:16 +0000 (UTC) Date: Fri, 17 May 2024 06:48:16 +0000 From: Alexey Dokuchaev To: Vladimir Druzenko Cc: Tobias Kortkamp , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5c97fbea8cb6 - main - *: Spell PORTREVISION correctly Message-ID: References: <202405131305.44DD5p58063913@gitrepo.freebsd.org> <714f05a7-007a-4f16-991e-c53d36f9a083@freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <714f05a7-007a-4f16-991e-c53d36f9a083@freebsd.org> On Thu, May 16, 2024 at 10:15:34PM +0300, Vladimir Druzenko wrote: > 13.05.2024 16:05, Tobias Kortkamp пишет: > > commit 5c97fbea8cb6cc44d19d98a9fa77db86410aebed > > > > -PORTEVISION= 1 > > -POPRTREVISION= 1 > > -PORTREvISION= 1 > > -PORTREVISIOMN= 1 > > -PORTERVISION= 1 > > -PORTREVIDSION= 1 > > -PORTREVSION= 1 > > -PORTREVIDSION= 1 > > -PORTREIVSION= 1 > > -PORTREVISIOPN= 1 > > -PORTREVISIOn= 1 > > -PORTEVISION= 1 > > -PORTREVIDSION= 1 > > They look like typos when entered manually. Yup, looks like it, IDK why people seldom or never do "make -V PKGNAME" before commit to rule out potential typos. > Wouldn't it be better to make use PORTREVISION on every port mandatory? > It's also easier to do a mass bump. Nah, that would be disgusting! Forced PORTREVISION lines would add lots of needless cognitive load on the Makefile reader, let alone the repo churn itself. I'm generally against artificial harness against people's stupidity. It might help stupid people, but at the expense of smart and careful ones' comfort. Just don't forget to "make -V PKGNAME" and we all would be fine. :-) ./danfe