From owner-svn-src-head@freebsd.org Sun Nov 24 16:32:45 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CACBC1B3B99; Sun, 24 Nov 2019 16:32:45 +0000 (UTC) (envelope-from freebsd@bdragon.rtk0.net) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47LbLN2JTGz4Bs6; Sun, 24 Nov 2019 16:32:43 +0000 (UTC) (envelope-from freebsd@bdragon.rtk0.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 24D41226CA; Sun, 24 Nov 2019 11:32:43 -0500 (EST) Received: from imap1 ([10.202.2.51]) by compute5.internal (MEProxy); Sun, 24 Nov 2019 11:32:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=RCMnID SjUKr8BIMRDiAO7zplnszgUNVMoUMXczTZfJw=; b=AemZInnZIoHoWfUCFTjKdk ifWIvloBv3a/yZGp0zWc8tJBfTYcJuJtBWsqX98VKndrYdHp+ez3a5zNRNjn5mRv evWC53eimlqXijYD8SswPULeZnwPziSBis7Jk6odc4vh21HpgzNZSWIzdCDU96lc IRNdY79maM87a2eM1HEKWC2YS1AkfCW1tkrd6xV7OT8FlXmlo+IsaahdcJFd5m5y /nv/cXXxpPHNWCb+WQn7jr+G8dHncwm8NKLj4GYJBeG5WHPYYuLJN/M488zrOEio FGFSpAvwWvr26TiKkiGyybYd/971FDsv8HLvVowmnYX4Xq2VrieJW9Q9imnmjVPg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehkedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdeurhgr nhguohhnuceuvghrghhrvghnfdcuoehfrhgvvggsshgusegsughrrghgohhnrdhrthhktd drnhgvtheqnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehfrhgvvggsshgusegsughrrghgohhnrdhrthhktddrnhgvthenucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 809E6C200A4; Sun, 24 Nov 2019 11:32:42 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1 Mime-Version: 1.0 Message-Id: <849a4306-1cf7-4296-b594-236caa1572a0@www.fastmail.com> In-Reply-To: <20191124130441.GA2707@kib.kiev.ua> References: <201911240435.xAO4ZTgw070233@repo.freebsd.org> <20191124130441.GA2707@kib.kiev.ua> Date: Sun, 24 Nov 2019 10:32:23 -0600 From: "Brandon Bergren" To: "Konstantin Belousov" , "Justin Hibbits" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355045 - head/libexec/rtld-elf/powerpc Content-Type: text/plain X-Rspamd-Queue-Id: 47LbLN2JTGz4Bs6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=AemZInnZ; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@bdragon.rtk0.net has no SPF policy when checking 66.111.4.29) smtp.mailfrom=freebsd@bdragon.rtk0.net X-Spamd-Result: default: False [-4.88 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[messagingengine.com:s=fm1]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; IP_SCORE(-3.49)[ip: (-9.83), ipnet: 66.111.4.0/24(-4.87), asn: 11403(-2.68), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[rtk0.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[messagingengine.com:+]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_LOW(-0.10)[29.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; MID_RHS_WWW(0.50)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Nov 2019 16:32:45 -0000 On Sun, Nov 24, 2019, at 7:04 AM, Konstantin Belousov wrote: > On Sun, Nov 24, 2019 at 04:35:29AM +0000, Justin Hibbits wrote: > > Author: jhibbits > > Date: Sun Nov 24 04:35:29 2019 > > New Revision: 355045 > > URL: https://svnweb.freebsd.org/changeset/base/355045 > > > > Log: > > rtld/powerpc: Fix _rtld_bind_start for powerpcspe > > > > Summary: > > We need to save off the full 64-bit register, not just the low 32 bits, > > of all registers getting saved off in _rtld_bind_start. Additionally, > > we need to save off the other SPE registers (SPEFSCR and accumulator), > > so that their program state is not affected by the PLT resolver. > Why do you need to save these registers ? Why would rtld touch them ? > Out of a need to make the binder as invisible as possible when interacting with code that may or may not be following the normal ABI rules regarding who is responsible for saving stuff. It's not just C code using it.