Date: Mon, 17 Jul 2023 10:48:08 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Nuno Teixeira <eduardo@freebsd.org> Cc: FreeBSD Mailing List <freebsd-ports@freebsd.org>, Po-Chuan Hsieh <sunpoet@freebsd.org> Subject: Re: www/node18 fails to build on aarch64/current Message-ID: <3500818A-B09B-48F1-80FD-7BC419E386BF@FreeBSD.org> In-Reply-To: <CAFDf7UJpjZkNXktcRZAUY3KQpCge9vJb3abYj7uuqKTwucAeNw@mail.gmail.com> References: <CAFDf7ULB281n-aiWt5MVuo1XPjwbYhPf2GpVHnZonN0PF4YquQ@mail.gmail.com> <06E66577-0A59-4BCD-BCD8-9C1BC2B6F17C@FreeBSD.org> <CAFDf7UJe0pLKUag4%2BSXs-iS2vWQ45P-Av-BM9EPO2aXLpE7X1g@mail.gmail.com> <CAFDf7U%2BHW%2BeKREA4wwvVjGk%2BtR6FF3hRtQxg6r%2BPDh39Ye3HAw@mail.gmail.com> <CAFDf7UJpjZkNXktcRZAUY3KQpCge9vJb3abYj7uuqKTwucAeNw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D7830E88-72EE-442D-AFFA-6ED3C20E83E3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Probably the particular enums it complains about are only hit on = aarch64. It may also be that it already partially has the actual fixes = from v8 for this issue: = https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0cb= 2b77a0db203f -Dimitry > On 17 Jul 2023, at 10:33, Nuno Teixeira <eduardo@freebsd.org> wrote: >=20 > (...) >=20 > More strange is that I can only reproduce this on aarch64. amd64 seems = to build fine... > Any clues? >=20 > Nuno Teixeira <eduardo@freebsd.org> escreveu no dia segunda, = 17/07/2023 =C3=A0(s) 07:53: > I can confirm that it builds. >=20 > Should a PR be open or this is being taken already? >=20 > Thanks, >=20 > Nuno Teixeira <eduardo@freebsd.org> escreveu no dia domingo, = 16/07/2023 =C3=A0(s) 14:24: > Hello Dimitry! >=20 > Thanks, I didn't see that PR since I only searched node18... >=20 > I'm building it right now with: >=20 > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 > +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion > +.endif >=20 > Tomorrow I will have results. >=20 > Thanks! >=20 > Dimitry Andric <dim@freebsd.org> escreveu no dia domingo, 16/07/2023 = =C3=A0(s) 14:10: > On 16 Jul 2023, at 14:58, Nuno Teixeira <eduardo@freebsd.org> wrote: > > > > main 1400093 aarch64 > > > > Anyone seeing www/node18 failing (needed for www/firefox)? > > I tried reverting latest 2 committs and same result with 18.16.0. > > > > Any hints? > > > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.1.log > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.0.log >=20 > These are similar to <https://bugs.freebsd.org/272013>, but instead of = properly fixing it, the can was kicked down the road in = <https://cgit.freebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de8= 2b8dd49950d>. >=20 > These enums should be fixed by either removing the values outside of = the enum's valid range, or by specifying the enum's underlying type = explicitly to allow for such values. In the near future the = -Wno-enum-constexpr-conversion flag is going to go away! >=20 > -Dimitry >=20 >=20 >=20 > -- > Nuno Teixeira > FreeBSD Committer (ports) >=20 >=20 > -- > Nuno Teixeira > FreeBSD Committer (ports) >=20 >=20 > -- > Nuno Teixeira > FreeBSD Committer (ports) --Apple-Mail=_D7830E88-72EE-442D-AFFA-6ED3C20E83E3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZLUASAAKCRCwXqMKLiCW oyI8AJ9jd8iL/6JsykyjQ3tyWT/6PFuMLwCfTA6v7AmkGJUSNOnqyEI3SfE8TuI= =vnLd -----END PGP SIGNATURE----- --Apple-Mail=_D7830E88-72EE-442D-AFFA-6ED3C20E83E3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3500818A-B09B-48F1-80FD-7BC419E386BF>