From owner-freebsd-ports@FreeBSD.ORG Thu Feb 26 13:25:40 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B861016A4CE for ; Thu, 26 Feb 2004 13:25:40 -0800 (PST) Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A3DF43D2F for ; Thu, 26 Feb 2004 13:25:40 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (960847b45829a4f7a8c386fd3d332ba6@adsl-67-119-53-203.dsl.lsan03.pacbell.net [67.119.53.203]) by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i1QLPa83015291; Thu, 26 Feb 2004 13:25:37 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 2A70F66CAF; Thu, 26 Feb 2004 13:25:36 -0800 (PST) Date: Thu, 26 Feb 2004 13:25:36 -0800 From: Kris Kennaway To: Ion-Mihai Tetcu Message-ID: <20040226212536.GA7216@xor.obsecurity.org> References: <20040226232358.71a31aa5@it.buh.cameradicommercio.ro> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: <20040226232358.71a31aa5@it.buh.cameradicommercio.ro> User-Agent: Mutt/1.4.1i cc: ports@FreeBSD.ORG Subject: Re: one or more patch files / optional patch ? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2004 21:25:40 -0000 --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 26, 2004 at 11:23:58PM +0200, Ion-Mihai Tetcu wrote: > Hi, >=20 >=20 > The Porters Handbook says "To make fixes and upgrades easier, you should > avoid having more than one patch fix the same file"; I'm in the reverse > situation, e.g. I have to patch 4 files for adding a feature to a port. > It will only make sense to patch all the files or none. Should the patch > be split in 4 files or not ? Yes, I think this is also documented in the porter's handbook. It's a real pain in the ass to update patches when there's more than one patch per file. > I also want to use OPTIONS to allow the user to choose if he wants this > feature or not. How can I integrate this with patch target (e.g. having > the patch in files/ but only applied if WITH_ is set) ? EXTRA_PATCHES Kris --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAPmRPWry0BWjoQKURAnA3AJ4rGI0OZPxGwudcj6i4Emdynss7EQCeKpZq ChOiK5XFhJ4ePu/Lze/srJM= =/VvE -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--